Make _getEditableNode more efficient

RESOLVED FIXED in mozilla34

Status

()

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: tomasz, Assigned: tomasz)

Tracking

unspecified
mozilla34
x86
macOS
Points:
1
Bug Flags:
firefox-backlog +
qe-verify -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
_getEditableNode in Finder.jsm is slow because it traverses the DOM all the way up for all non-editable matches.

This started in bug 429732 comment 26.
(Assignee)

Updated

4 years ago
Assignee: nobody → tkolodziejski
Status: NEW → ASSIGNED
(Assignee)

Updated

4 years ago
Blocks: 429732
(Assignee)

Comment 1

4 years ago
Created attachment 8481468 [details] [diff] [review]
find-geteditablenode.patch

This was originally r+ by :ehsan in bug 429732 comment 42.

Try run:
https://tbpl.mozilla.org/?tree=Try&rev=8de84e77b8dd
Attachment #8481468 - Flags: review+
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
Points: --- → 1
Flags: qe-verify?
Flags: firefox-backlog+
Iteration: --- → 35.1
Flags: qe-verify? → qe-verify-
(Assignee)

Comment 3

4 years ago
This got in (https://hg.mozilla.org/mozilla-central/rev/ed1973bacb15) but it was reported in bug 429732 comment 56. So I think we can close it, right?

Comment 4

4 years ago
Yep!
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED

Updated

4 years ago
Target Milestone: --- → mozilla34
You need to log in before you can comment on or make changes to this bug.