1060542 - [Calendar] Week view: changing the date should also set the selected day on month view

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Calendar, defect)

Description

[Miller Medeiros [:millermedeiros]]

this is a regression caused by the new 5-day week view. We also need to set the "selected day" on the time controller, not only the "position".

Comment 1

[Miller Medeiros [:millermedeiros]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23512

Comment 2

[Gareth Aye [:gaye] (back from PTO)]

What is the bug?

Comment 3

[Jordan de Geus(JordanD)]

I am not seeing this occur on Flame 2.1 (319mb)  

Actual:
When users enter Calendar and select a date then switch to week view, upon changing/scrolling to another week then returning to the month view, users will see the date highlighted that was previously selected.

STR
1. Launch Calendar App
2. Tap on any date within Month View
3. Tap on Week 
4. Scroll horizontally to change to a different week
5. Select Month View again and observe previously selected date from step 2 is highlighted

Environmental Variables:
Device: Flame 2.1 (319mb)
Build ID: 20140903000204
Gaia: fbb297c39aab5f17b179533d2a9a6c5166b2c197
Gecko: fb5e796da813
Version: 34.0a2 
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Comment 4

[Miller Medeiros [:millermedeiros]]

The user story was confusing... the behavior should be the same as the day view (switching to a different day should also change the highlighted day on the month view)

Comment 5

[Miller Medeiros [:millermedeiros]]

[Blocking Requested - why for this release]: this is a regression introduced by a 2.1 feature

Comment 6

[Gareth Aye [:gaye] (back from PTO)]

Is this actually the behaviour that we want (regardless of whether it changed from 2.0 to 2.1)?

Comment 7

[Miller Medeiros [:millermedeiros]]

(In reply to Gareth Aye [:gaye] from comment #6)
> Is this actually the behaviour that we want (regardless of whether it
> changed from 2.0 to 2.1)?

yes it is.. Harly reported the bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1023662#c15

Comment 8

[Gareth Aye [:gaye] (back from PTO)]

Comment on attachment 8481583 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23512

OK LGTM thanks!

Comment 9

[Gareth Aye [:gaye] (back from PTO)]

https://github.com/mozilla-b2g/gaia/commit/b9e4f254733b7285e01837f2ceadf43fe3657bc2

Comment 10

[Dylan Oliver [:doliver]]

triage: Not blocking 2.1. This is a fairly minor regression and I would guess it's not a core use case. Please re-nominate if you disagree.

The month view does reflect the appropriate month for whatever week you had been looking at in week view, it just doesn't select the day.

Comment 11

[Harly Hsu[:harly]]

I think this is an important UX bug which could impact the overall usability for calendar, and it would be great if we could have it fixed in 2.1.

Comment 12

[Edward Chen[:edchen]]

[Environment]
Gaia      e731a63484c532168f4de6dc1eeb4c6612ad73a9
Gecko     https://hg.mozilla.org/releases/mozilla-aurora/rev/868cc9e5e32a
BuildID   20140915160206
Version   34.0a2
ro.build.date   Fri Jun 27 15:57:58 CST 2014
ro.bootloader   L1TC00011230
ro.build.version.incremental   110

[Result]
PASS