The default bug view has changed. See this FAQ.

[email] Update BrowserBox and SmtpClient libs when they support STARTTLS

RESOLVED FIXED

Status

Firefox OS
Gaia::E-Mail
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: mcav, Unassigned)

Tracking

unspecified
x86_64
Linux
Dependency tree / graph

Firefox Tracking Flags

(b2g-v2.1 fixed, b2g-v2.2 fixed)

Details

(Reporter)

Description

3 years ago
Per the email.js transition in bug 885110, BrowserBox and SmtpClient did not support STARTTLS, so we monkeypatched it in js/imap/client.js and js/smtp/client.js. When these libraries release new versions with support for that, we should remove our monkeypatches.
(Reporter)

Updated

3 years ago
See Also: → bug 885110
(Reporter)

Comment 1

3 years ago
The corresponding issues on GitHub:

https://github.com/whiteout-io/browserbox/issues/20
https://github.com/whiteout-io/smtpclient/ues/8
Note that both originals issues have been closed, but the patches landed thus far are for opportunistic STARTTLS support and do not mandate it, so they aren't entirely suitable yet.  At least per our bug-filing idiom, I've created new issues rather than reopening.  They are:

https://github.com/whiteout-io/browserbox/issues/28
https://github.com/whiteout-io/smtpclient/issues/13
Blocks: 1080543
Depends on: 1097421

Comment 3

2 years ago
Looking at the upstream bugs, issue 28 seems fixed (closed upstream, relevant test seems to be here [1]) and so does issue 13 (closed upstream, pull request [2]).

Is there anything else that is blocking this bug/that this bug is tracking?

1: https://github.com/whiteout-io/browserbox/blob/76baf18ce919322d1d7bb5a7c23a91074ca5908c/test/integration/browserbox-test.js#L161

2: https://github.com/whiteout-io/smtpclient/pull/14

Is this bug
Fixed as part of bug 1097421's omnibus patch. Many servers were experiencing more than one bug, and we had experienced some upstream drift, and especially for uplift tracking, it made sense to land these together.  See the gaia-email-libs-and-more pull request's specific commits for the specific fixes and tests.  I am planning to request v2.1 uplift shortly after performing v2.1 testing.
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-b2g-v2.1: --- → affected
status-b2g-v2.2: --- → fixed
Resolution: --- → FIXED
Batching marking v2.1 fixed since the uplift of bug 1097421 occurred on Dec 9th, thereby fixing all dependent bugs of bug 1097421 on v2.1.  Uplift commit comment is https://bugzilla.mozilla.org/show_bug.cgi?id=1097421#c6
status-b2g-v2.1: affected → fixed
You need to log in before you can comment on or make changes to this bug.