1060621 - WorkerScope should CC mLocation and mNavigator

Status: RESOLVED FIXED

(Core :: DOM: Workers, defect)

Description

[Boris Zbarsky [:bzbarsky]]

It doesn't, but that seems odd.  Why doesn't it?  Should at least be documented.

Comment 1

[Andrea Marchesini [:baku]]

Attachment: cc.patch

This fixes bug 1061720.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8482785 [details] [diff] [review]
cc.patch

r=me; add the testcase?

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Do we want this on branches? Should be rather safe patch.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Might not be a bad idea.  I guess this has been a problem for a while....

Comment 5

[Andrea Marchesini [:baku]]

Attachment: cc.patch

https://tbpl.mozilla.org/?tree=Try&rev=92d3350aab22

Comment 6

[Andrew McCreight [:mccr8]]

Can you also put in a test for an expando on location?

Comment 8

[Andrea Marchesini [:baku]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/eeb169601087

Comment 9

[Andrea Marchesini [:baku]]

(In reply to Andrew McCreight [:mccr8] from comment #6)
> Can you also put in a test for an expando on location?

ah sorry... I didn't see your comment. I'll do in the other patch about WorkerNavigator.location.

Comment 10

[Ryan VanderMeulen (PTO, back 6-April)]

https://hg.mozilla.org/mozilla-central/rev/eeb169601087

Comment 11

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 8482815 [details] [diff] [review]
cc.patch

Approval Request Comment
[Feature/regressing bug #]: We need this to land bug 1062920 without leaking.
[User impact if declined]: We won't take bug 1062920
[Describe test coverage new/current, TBPL]: Worker code is well tested in automation.
[Risks and why]: Low risk
[String/UUID change made/needed]: N/A

Comment 12

[Ryan VanderMeulen (PTO, back 6-April)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/13895d27efd0
https://hg.mozilla.org/releases/mozilla-beta/rev/32d5ee00c3ab