Closed
Bug 1060730
Opened 10 years ago
Closed 10 years ago
Turn updateICEContacts() into a Promise.all() barrier
Categories
(Firefox OS Graveyard :: Gaia::Dialer, defect)
Firefox OS Graveyard
Gaia::Dialer
Tracking
(Not tracked)
RESOLVED
FIXED
2.1 S5 (26sep)
People
(Reporter: drs, Assigned: gtorodelvalle)
References
Details
(Whiteboard: [planned-sprint])
Attachments
(1 file)
During review of bug 1038701, Anthony suggested using a Promise.all() barrier for the updateICEContacts() function instead of writing our own poor man's implementation. See https://github.com/mozilla-b2g/gaia/pull/23322/files#r16893786
|
||
Comment 1•10 years ago
|
||
I suggested that but if it makes the code too complex or unreadable, let's not do it.
|
Reporter | |
Updated•10 years ago
|
Blocks: dialer-most-wanted
Whiteboard: [dialer-most-wanted] → [planned-sprint]
|
|
Reporter | |
Updated•10 years ago
|
Target Milestone: 2.1 S4 (12sep) → 2.1 S5 (26sep)
|
|
Reporter | |
Updated•10 years ago
|
Assignee: nobody → anthony
|
|
Reporter | |
Updated•10 years ago
|
Assignee: anthony → gtorodelvalle
|
|
Reporter | |
Comment 2•10 years ago
|
||
Germán, do you think you'll be able to get to this during this sprint? Please reassign to me if you don't think so.
Flags: needinfo?(gtorodelvalle)
|
||
Updated•10 years ago
|
QA Whiteboard: [ICE]
|
Assignee | |
Comment 3•10 years ago
|
||
Hi Anthony, was this what you had in mind? Thanks!
Attachment #8495871 -
Flags: review?(anthony)
Flags: needinfo?(gtorodelvalle)
|
|
||
Comment 4•10 years ago
|
||
Comment on attachment 8495871 [details] [review]
PR 24468
Totally, so much cleaner! Thanks!
Attachment #8495871 -
Flags: review?(anthony) → review+
|
|
Assignee | |
Comment 5•10 years ago
|
||
Merged in master: https://github.com/mozilla-b2g/gaia/commit/a45a202061f0cc29765176a2803a175d6ada221d
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•