1060769 - PLATFORMS_BUILDERNAME's 'os_platform' is a mixture of OS type, OS version, architecture & product name

Status: RESOLVED WONTFIX

(Tree Management :: Treeherder, defect)

Description

[Ed Morley [:emorley]]

For example:

b2g-linux64
mulet-linux64
linux32
b2g-osx
osx-10-9
b2g-win32
windowsxp
windows8-32
android-4-0
android-2-2-armv6
b2g-emu-jb

Each value contains some but not necessary all of:
* OS type (eg android vs windows)
* OS version (eg win "XP vs 8", android "2.2 vs 4.0")
* Architecture (32 vs 64)
* Product name (eg mulet)

The problems with this:
* We don't include all of the above in each os_platform, so is inconsistent
* 'os_platform' as a property name doesn't reflect what we're actually using it for (a pseudo unique type identifier for determining whether something gets it's own row in the results in the treeherder UI)
* Some of the names seem to reflect more what the product is, whereas others reflect on what platform it is being run (eg "mulet-linux64" vs "b2g-emu-jb". The former is a separate product being run on linux64, the latter is firefox being run on a b2g emulator running a fork of Android jelly bean).

Comment 1

[Ed Morley [:emorley]]

Proposal:
* When we ingest jobs, make sure that each of the scraps of data we're inferring (and currently placing into os_platform) are stored in their own property (we already do this for things like 'os' and 'arch' in buildbot.py)
* Rename 'os_platform' to 'display_category' or something to reflect it's really a UI categorisation thing
* Add missing properties (eg product) to the values we already have (eg: "linux32" -> "firefox-linux32", "windowsxp" -> "firefox-windowsxp" etc).
* Fix all this up for previously ingested data (since otherwise I guess the UI will struggle to cope when viewing old data and using things like the visibility profiles).

Comment 2

[Ed Morley [:emorley]]

This bug was originally about buildbot but still applies to Taskcluster, however would be a massive undertaking to fix, so let's punt on it until we have a strong reason to do so.