1061009 - Fix more bad implicit constructors in a11y

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Comment 1

[(no longer active)]

Attachment: Fix more bad implicit constructors in a11y

Comment 2

[Trevor Saunders (:tbsaunde)]

Comment on attachment 8482015 [details] [diff] [review]
Fix more bad implicit constructors in a11y

> class xpcAccessibleTable
> {
> public:
>-  xpcAccessibleTable(mozilla::a11y::TableAccessible* aTable) : mTable(aTable) { }
>+  explicit xpcAccessibleTable(mozilla::a11y::TableAccessible* aTable) : mTable(aTable) { }

really long line, please break it.

>+++ b/accessible/xpcom/xpcAccessibleTableCell.h
>@@ -20,17 +20,17 @@ class TableCellAccessible;
> 
> /**
>  * This class provides an implementation of the nsIAccessibleTableCell
>  * interface's methods.
>  */
> class xpcAccessibleTableCell
> {
> public:
>-  xpcAccessibleTableCell(mozilla::a11y::TableCellAccessible* aTableCell) :
>+  explicit xpcAccessibleTableCell(mozilla::a11y::TableCellAccessible* aTableCell) :
>     mTableCell(aTableCell) { }

same

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1116b6fce5f5

Comment 4

[(no longer active)]

I'm sorry, I didn't see the review comments...  Addressed them here: https://hg.mozilla.org/integration/mozilla-inbound/rev/8916e598fa3f

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8916e598fa3f