Closed Bug 1061122 Opened 10 years ago Closed 10 years ago

Unable to make call when tapping on call log items with two SIMs

Categories

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Dialer
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(b2g-v2.0 unaffected, b2g-v2.1 affected)

Status:
VERIFIED FIXED
Milestone:
2.1 S4 (12sep)
Tracking Flags:
Tracking Status
b2g-v2.0 --- unaffected
b2g-v2.1 --- affected

People

(Reporter: ericcc, Assigned: rik)

References

Details

(Keywords: qablocker, regression, Whiteboard: [xfail])

Attachments

(1 file)

https://github.com/mozilla-b2g/gaia/pull/23584
46 bytes, text/x-github-pull-request
etienne
: review+
Details | Review 
### STR
1. Have some items in call log.
2. Single tap on any of them

### Actual
Call not made

### Expected
Call made, call screen shown.

#version
Gaia      2be78d83a760fa3b9638fe51c266b442d14597f1
Gecko     https://hg.mozilla.org/mozilla-central/rev/1db35d2c9a2f
BuildID   20140831160203
Version   34.0a1
ro.build.version.incremental=110
ro.build.date=Fri Jun 27 15:57:58 CST 2014
B1TC00011230
[Blocking Requested - why for this release]: Regression, Breaks  v2.0 user story Bug 920011 - [User Story] Dialing from call log
https://bugzilla.mozilla.org/attachment.cgi?id=8403783
blocking-b2g: --- → 2.1?
QA Whiteboard: [COM=Gaia::Dialer]
Depends on: 877971
Taking this since this is a pretty bad regression.
Assignee: nobody → anthony
Target Milestone: --- → 2.1 S4 (12sep)
For a device with two sims, I'm seeing this error:

"FontSizeUtils is not defined" when calling KeypadManager.updatePhoneNumber in call_log.js.

Testing on a device with one SIM.
Can't see the error with only one SIM.
This was broken by bug 1011601 because it removed font_size_utils which is needed to resize the number typed on the keypad. Therefore, it also broke the dynamic resizing of this.
Depends on: 1011601
No longer depends on: 877971
Summary: [Calllog][Dialer] Unable to make call when tapping on call log items → Unable to make call when tapping on call log items with two SIMs

        Attachment #8482319 -
        Flags: review?(etienne)

    
    

    
  
https://github.com/mozilla-b2g/gaia/commit/1b78137e746ab6862d01eba00eaec8b0b4c83cf6
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Keywords: qablocker
Whiteboard: [xfail]
blocking-b2g: 2.1? → ---

    
    

    
  
Tested and working 
Flame
2.1
Gecko: 06f3a69
Gaia: 47939f4
Status: RESOLVED → VERIFIED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: