1061122 - Unable to make call when tapping on call log items with two SIMs

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Eric Chang [:ericcc] [:echang]]

### STR
1. Have some items in call log.
2. Single tap on any of them

### Actual
Call not made

### Expected
Call made, call screen shown.

#version
Gaia      2be78d83a760fa3b9638fe51c266b442d14597f1
Gecko     https://hg.mozilla.org/mozilla-central/rev/1db35d2c9a2f
BuildID   20140831160203
Version   34.0a1
ro.build.version.incremental=110
ro.build.date=Fri Jun 27 15:57:58 CST 2014
B1TC00011230

Comment 1

[Eric Chang [:ericcc] [:echang]]

[Blocking Requested - why for this release]: Regression, Breaks  v2.0 user story Bug 920011 - [User Story] Dialing from call log
https://bugzilla.mozilla.org/attachment.cgi?id=8403783

Comment 2

[Anthony Ricaud (:rik)]

Taking this since this is a pretty bad regression.

Comment 3

[Anthony Ricaud (:rik)]

For a device with two sims, I'm seeing this error:

"FontSizeUtils is not defined" when calling KeypadManager.updatePhoneNumber in call_log.js.

Testing on a device with one SIM.

Comment 4

[Anthony Ricaud (:rik)]

Can't see the error with only one SIM.

Comment 5

[Anthony Ricaud (:rik)]

This was broken by bug 1011601 because it removed font_size_utils which is needed to resize the number typed on the keypad. Therefore, it also broke the dynamic resizing of this.

Comment 6

[Anthony Ricaud (:rik)]

Attachment: https://github.com/mozilla-b2g/gaia/pull/23584

Comment 8

[Etienne Segonzac (:etienne)]

Comment on attachment 8482319 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/23584

lgtm

Comment 9

[Anthony Ricaud (:rik)]

https://github.com/mozilla-b2g/gaia/commit/1b78137e746ab6862d01eba00eaec8b0b4c83cf6

Comment 10

[Loli (:lolimartinezcr)]

Tested and working 
Flame
2.1
Gecko: 06f3a69
Gaia: 47939f4