1061135 - The 12/24 hour format ui tests have race condition issues.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Calendar, defect)

Description

[Evan Tseng [:evanxd]]

There are many 12/24 hour format tests are failed intermittently. These[3][4] are the failures.

The root cause probably is that when navigator.mozHour12 is the default value as `null`[1] Calendar app render the date/time element by 24 format[2] but the hour format settings value is actually "12 hour format". So the race condition problem of Gij tests will probably happen.

[1] https://github.com/mozilla-b2g/gaia/blob/master/shared/js/date_time_helper.js#L15
[2] https://github.com/mozilla-b2g/gaia/blob/master/apps/calendar/js/calc.js#L48-L50
[3] https://tbpl.mozilla.org/php/getParsedLog.php?id=47159527&tree=Gaia-Try&full=1#error0
[4] https://tbpl.mozilla.org/php/getParsedLog.php?id=47158799&tree=Gaia-Try#error0

Comment 1

[Evan Tseng [:evanxd]]

We could disable the related tests first, then find a good way to fix this issue.

Comment 2

[Evan Tseng [:evanxd]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23566

Comment 3

[Evan Tseng [:evanxd]]

Attachment: PR to disable the intermittent failing tests

Comment 4

[Evan Tseng [:evanxd]]

Comment on attachment 8482206 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23566

Hi Miller,

Could you give me feedback for the patch?

Thanks.

Comment 5

[Evan Tseng [:evanxd]]

These are the failed jobs:
1. https://tbpl.mozilla.org/php/getParsedLog.php?id=47161917&tree=Gaia-Try#error0
2. https://tbpl.mozilla.org/php/getParsedLog.php?id=47162956&tree=Gaia-Try#error0
3. https://tbpl.mozilla.org/php/getParsedLog.php?id=47161944&tree=Gaia-Try#error2
4. https://tbpl.mozilla.org/php/getParsedLog.php?id=47162417&tree=Gaia-Try#error3
5. https://tbpl.mozilla.org/php/getParsedLog.php?id=47161911&tree=Gaia-Try#error0

Comment 6

[Miller Medeiros [:millermedeiros]]

Comment on attachment 8482206 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23566

I think we should not change the application code (in a weird way) to avoid test errors.. added more comments on github.

Comment 7

[Evan Tseng [:evanxd]]

Yes, you're right.

But after investigate deeper,
I found out the root cause of this issue is that
the `navigator.mozHour12` is just always `null`, and it is a bug of `navigator.mozSettings`.

I will file a bug for it, and that will block this bug.

Comment 8

[Evan Tseng [:evanxd]]

Sorry, the `navigator.mozHour12` keeps as `null` "intermittently".

Comment 9

[Evan Tseng [:evanxd]]

Attachment: PR to re-enable the tests

Comment 10

[Evan Tseng [:evanxd]]

The tests are passed in try-server for 11 times[1]. So let's re-enable them.

[1] https://tbpl.mozilla.org/?rev=dec42eca16525c5d04e565ffe1caf9a28a7a53df&tree=Gaia-Try

Comment 11

[Evan Tseng [:evanxd]]

master: https://github.com/mozilla-b2g/gaia/commit/f66ddd50bc914019f6efdc9abfea29c211ca9434