1061149 - [Calllog][Dialer] Phone number is showed with different color in incoming/out/missed calls (in "Call info" screen)

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Loli (:lolimartinezcr)]

Flame
2.1
Gecko-4d85c35
Gaia-561f053

Pre-requisites:
Incoming, out and missed calls in call log.

STRs:
1. Tap in dialer application.
2. Tap in call log button.
3. Long-Tap in incoming call 
4. Tap in "Call information" button -> Actual result 1
5. Back
6. Long-Tap in missed call
7. Tap in "Call information" button -> Actual result 2
8. Back
9. Long-Tap in outgoing call
10. Tap in "Call information" button -> Actual result 3

Actual result 1: In incoming call, phone number is showed in red color.
Actual result 2: In missed call, phone number is showed in red color.
Actual result 3: In outgoingcall, phone number is showed in blue color.

Expected result:
Incoming an outgoing calls should be showed in blue color (UX need info)

Comment 1

[Anthony Ricaud (:rik)]

Moving into the sprint because it is an implementation issue that doesn't follow the spec.

Comment 2

[Maria Angeles Oteo (:oteo)]

[Blocking Requested - why for this release]:

Nominating to 2.1 because the implementation does not follow the spec in https://bug877971.bugzilla.mozilla.org/attachment.cgi?id=8463237 where on page 5 says "If the contact has set more than one number, the one related to the call log will display in different colour (blue for normal
calls, red for missed calls)

Comment 3

[Doug Sherk (:drs) (inactive)]

Attachment: Fix incoming but not missed calls having their numbers displayed in red on call info page.

PR: https://github.com/mozilla-b2g/gaia/pull/23650

Comment 4

[Anthony Ricaud (:rik)]

Comment on attachment 8483125 [details] [diff] [review]
Fix incoming but not missed calls having their numbers displayed in red on call info page.

Review of attachment 8483125 [details] [diff] [review]:
-----------------------------------------------------------------

Nice cleanup as part of this.

Comment 5

[Doug Sherk (:drs) (inactive)]

https://github.com/mozilla-b2g/gaia/commit/8d3cbc95da3dfdc4677f15a767b6ca28d26fe8f4

Comment 6

[Loli (:lolimartinezcr)]

Tested and *not working*
Flame
2.1
Gecko-039bd5d
Gaia-95e9b09

Comment 7

[Anthony Ricaud (:rik)]

If it is not working, please reopen the bugs so we can do something about it.

Comment 8

[Doug Sherk (:drs) (inactive)]

This hasn't been uplifted to 2.1, so that would explain why it's not working.

Comment 9

[Doug Sherk (:drs) (inactive)]

Comment on attachment 8483125 [details] [diff] [review]
Fix incoming but not missed calls having their numbers displayed in red on call info page.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): bug 877971
[User impact] if declined: Incoming calls will show up in red even if they're not missed.
[Testing completed]: Anthony and I tested it.
[Risk to taking this patch] (and alternatives if risky): Low.
[String changes made]: None.

Comment 10

[bhavana bajaj [:bajaj]]

(In reply to Maria Angeles Oteo (:oteo) from comment #2)
> [Blocking Requested - why for this release]:
> 
> Nominating to 2.1 because the implementation does not follow the spec in
> https://bug877971.bugzilla.mozilla.org/attachment.cgi?id=8463237 where on
> page 5 says "If the contact has set more than one number, the one related to
> the call log will display in different colour (blue for normal
> calls, red for missed calls)

Blocking due to this, else approval should have sufficed here.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/f2c37164a28ea710f2dcc44d7ac6ff248af3ae0d

Comment 12

[Loli (:lolimartinezcr)]

Tested and working
Flame 
2.1
Gecko-f816f7e
Gaia-c7b55ed

Comment 13

[[:RJ]]

This issue is verified fixed in flame 2.2 and flame 2.1 

As per the documentation on the call information screen Missed calls numbers are colored red, and regular calls numbers are colored blue.

Flame 2.2 Master KK (319mb) (Full Flash)

Device: Flame 2.2 Master KK (319mb) (Full Flash)
BuildID: 20141012040203
Gaia: 717ad4e8b7fc10ab8248500d00ba5ba0977fa8ab
Gecko: 44168a7af20d
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 35.0a1 (2.2 Master)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0


Flame 2.1 KK (319mb) (Full Flash)

Device: Flame 2.1 KK (319mb) (Full Flash)
BuildID: 20141012001201
Gaia: d18e130216cd3960cd327179364d9f71e42debda
Gecko: 610ee0e6a776
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 34.0a2 (2.1)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0