1061170 - constrain AvailableISize() when setting up reflow-state for orthogonal flows

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Jonathan Kew [:jfkthame]]

When we have an unconstrained available block-size, and need to construct an nsHTMLReflowState for an orthogonal child, this translates to an unconstrained inline-size. That's not good.

This results in a bunch of assertions in layout/style/test/test_value_cloning.html if vertical writing mode support is enabled (e.g. see https://tbpl.mozilla.org/?tree=Try&rev=3154154d61a1; the other patches in that push are irrelevant to this).

Comment 1

[Jonathan Kew [:jfkthame]]

Attachment: constrain the reflow-state's available inline size for an orthogonal flow.

As a first step to address this issue, here's a patch that makes the presShell pass down a size that can be used to limit orthogonal inline-sizes, at the time when it's setting the block-size to be unconstrained. With this, we could in theory enable vertical-mode support without instantly turning mochitests orange (although of course there are plenty of other things to finish before we actually do that).

Comment 2

[Simon Montagu :smontagu]

Comment on attachment 8482235 [details] [diff] [review]
constrain the reflow-state's available inline size for an orthogonal flow.

Review of attachment 8482235 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good code-wise. What testing have you done for performance impact?

Comment 3

[Jonathan Kew [:jfkthame]]

(In reply to Simon Montagu :smontagu from comment #2)

> What testing have you done for performance impact?

I haven't. Before worrying about that, I wanted to see if you agreed the general idea was sensible. 

Anyhow, AFAICS there should be no impact on horizontal-only documents, except for pathological cases with huge sizes (see the NS_WARN_IF_FALSE); if we do hit this case on any reasonable page, I think that would indicate a separate bug (and it'd probably end up asserting somewhere).

Comment 4

[Simon Montagu :smontagu]

Comment on attachment 8482235 [details] [diff] [review]
constrain the reflow-state's available inline size for an orthogonal flow.

Review of attachment 8482235 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, I think this makes sense as an opening bid, though we may decide to refine it after we see more test cases in action.

Comment 5

[Jonathan Kew [:jfkthame]]

OK, pushed this. (Yes, I expect we may well want to do more eventually.)

https://hg.mozilla.org/integration/mozilla-inbound/rev/01a10676eef1

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/01a10676eef1