106122 - xpti needs to use new, expanded, path keys on nsIDirectoryServiceProvider

Status: VERIFIED FIXED

(Core :: XPConnect, defect)

Description

[Judson Valeski]

Currently xpti uses a hardcoded path(s) to scan for xpt files. It should use
nsIDirectoryServiceProvider to get path info.

Comment 1

[John Bandhauer]

Well, xpti does use that service - and does not use any hardcoded paths. What it 
does need to do is start using the new keys that will be available when bug 
105440 is fixed.

Comment 2

[Judson Valeski]

updating summary from: "xpti needs to use nsIDirectoryServiceProvider to
determine scanning directories"

Comment 3

[Judson Valeski]

105440 is gone, nominating for edt0.9.4

Comment 4

[John Bandhauer]

Attachment: proposed fix (can't really test it until we have the list)

Comment 5

[Conrad Carlen (not reading bugmail)]

Use NS_APP_PLUGINS_DIR_LIST instead of NS_OS_PLUGINS_DIR_LIST. The "OS" list is
defined by the OS and contains plugins used by all apps, i.e, Flash, Acrobat,
QuickTime. The "APP" list is defined by the application (mozilla or an embedding
app). Other than that, looks good.

Comment 6

[John Bandhauer]

d'oh. I fixed the key in my tree.

Comment 7

[Judson Valeski]

conrad, what's the best way to test this? is there a provider that provides a
list for this key in one of the test harnesses?

Comment 8

[John Bandhauer]

Attachment: better patch

This fixes the problems with the previous patch 
- It uses Get instead of GetFiles (which does not do what was expected). 
- It uses the right key (NS_APP_PLUGINS_DIR_LIST).
- It fixes a prblem where the menifest reader did not the change when a
directory is added to the search path that was not there in the previous run.

Comment 9

[Conrad Carlen (not reading bugmail)]

Comment on attachment 57282 [details] [diff] [review]
better patch

This one is good. r=ccarlen

Comment 10

[Johnny Stenback (:jst)]

Comment on attachment 57282 [details] [diff] [review]
better patch

sr=jst

Comment 11

[John Bandhauer]

fix in trunk. Will prepare a patch for 0.9.4 branch.

Comment 12

[John Bandhauer]

So, this caused the blocker bug 109893. sfraser is going to checkin a oneliner 
to comment out the addition of the the plugins dir to the search path. I'm going 
to look at why that was a problem on Mac. On Mac they actually have a jar file 
in the plugins directory. I'm told that openning that file fails - perhaps due 
to a permissions problem. At minimum we need to understand that and also 
probably make it not fatal to fail in attempting to open a jar file when we are 
searching for interface infos.

Comment 13

[John Bandhauer]

Attachment: version of fix for the 0.9.4 branch

Same fix but for the 0.9.4 branch. Also includes the fix from bug 109893 - the
regression caused by the original patch here (since fixed in the trunk).

Comment 14

[Conrad Carlen (not reading bugmail)]

Comment on attachment 58089 [details] [diff] [review]
version of fix for the 0.9.4 branch

r=ccarlen

Comment 15

[Johnny Stenback (:jst)]

Comment on attachment 58089 [details] [diff] [review]
version of fix for the 0.9.4 branch

sr=jst

Comment 16

[John Bandhauer]

edt: This one is ready for 0.9.4. I'm waiting for your approval.

Comment 17

[Judson Valeski]

please checkin to the 0.9.4 branch when you have a chance. once landed, add
"fixed0.9.4" to the keyword field as well. Thanks!

Comment 18

[John Bandhauer]

fix checked in the 0.9.4 branch

Comment 19

[Phil Schwartau]

Marking Verified - 

Comment 20

[Phil Schwartau]

verified on 094

(i.e. patch verified on MOZILLA_0_9_4_BRANCH tag in CVS repository)