1061304 - Job navbar icons flow over bottom-left-bottom panel content

Status: VERIFIED FIXED

(Tree Management :: Treeherder, defect, P4)

Description

[Jonathan French (:jfrench)]

I think spawned from the work in bug 1042599, at reduced browser widths the job navbar icons (structured log, raw log, pinboard, retrigger job) now progressively overlay the bottom-left-bottom panel job status content.

I will attach a screen grab of that, and also a more fringe case (as yet unreproducible) in which the icons started to replicate themselves across the panel.

To reproduce the primary issue:
o open treeherder production
o click on a job
o reduce the width of the browser until flow is triggered in the job navbar

Observed
The icons flow over the job status content, obscuring it

Expected behavior
Since I assume the navbar should remain a fixed height, should they be clipped? Or should the current behavior remain and this be a WontFix? Or some other behavior.

Observed on both FF 31.0 Release and Google Chrome 37.0.2062.102m, at least on Windows.

Comment 1

[Jonathan French (:jfrench)]

Attachment: jobNavbarIconsFlow

This is the primary observed behavior.

Comment 2

[Jonathan French (:jfrench)]

Attachment: jobPanelNavbarIconsReplicated

This is the fringe, as-yet-unreproducible behavior.

Comment 3

[William Lachance (:wlach)]

It's hard to make this case work really well. It seems fair to me to have some kind of minimum acceptable screen size for treeherder where we expect it to be usable. That said, I think we should probably clip in this case (that's what e.g. Firefox developer tools does)

Comment 4

[Jonathan French (:jfrench)]

I agree clipping would be fine/preferred also, rather than the flow over the content.

Comment 5

[Jonathan French (:jfrench)]

I saw this bug in Ed's triage yesterday again, I'll just fix it now.

Comment 6

[Jonathan French (:jfrench)]

Attachment: treeherder-ui-PR#390

Please see above PR for status and review.

Comment 7

[William Lachance (:wlach)]

Comment on attachment 8569950 [details] [review]
treeherder-ui-PR#390

Looks good! Feel free to push this.

Comment 8

[Jonathan French (:jfrench)]

Thanks wlach!

Comment 9

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder-ui

https://github.com/mozilla/treeherder-ui/commit/0b607111e4cdc9bac454509d721afe16584facba
Bug 1061304 - Clip instead of flow job control icons

https://github.com/mozilla/treeherder-ui/commit/eef3b3e91c8568959ea4571402ae986d02376255
Merge pull request #390 from tojonmz/bottom-left-wrap

Bug 1061304 - Clip instead of flow job control icons

Comment 10

[Jonathan French (:jfrench)]

Marking fixed per above merge. I will verify on the next push to stage/prod.

Comment 11

[Jonathan French (:jfrench)]

Verified fixed on stage.

Comment 12

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/d89784419096791418afa57fb81a554aa04181ec
Bug 1061304 - Clip instead of flow job control icons

https://github.com/mozilla/treeherder/commit/419bc6c78747cebf059870587fd35bf4ed48bfd8
Merge pull request #390 from tojonmz/bottom-left-wrap

Bug 1061304 - Clip instead of flow job control icons