Closed
Bug 1061348
Opened 8 years ago
Closed 6 years ago
Port |Bug 575283 - Cleanup mozconfig files on all platforms| to SeaMonkey
Categories
(SeaMonkey :: Build Config, defect)
SeaMonkey
Build Config
Tracking
(seamonkey2.45 wontfix, seamonkey2.46 fixed, seamonkey2.47 fixed, seamonkey2.48 fixed, seamonkey2.49esr fixed)
RESOLVED
FIXED
seamonkey2.49
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
References
Details
Attachments
(2 files, 1 obsolete file)
16.37 KB,
patch
|
ewong
:
review+
Callek
:
approval-comm-aurora+
Callek
:
approval-comm-beta+
|
Details | Diff | Splinter Review |
17.85 KB,
patch
|
ewong
:
approval-comm-release+
|
Details | Diff | Splinter Review |
Bug 575283 cleaned up the in-tree mozconfigs for m-c, removing invalid and redundant options. This ports those changes to SeaMonkey.
Attachment #8482436 -
Flags: review?(bugspam.Callek)
Comment 1•8 years ago
|
||
Comment on attachment 8482436 [details] [diff] [review] Remove invalid / redundant options from mozconfigs Review of attachment 8482436 [details] [diff] [review]: ----------------------------------------------------------------- r- purely because there is more stuff to do. ::: suite/config/mozconfigs/linux32/debug @@ -14,4 @@ > > # For NSS symbols > export MOZ_DEBUG_SYMBOLS=1 > -ac_add_options --enable-debug-symbols="-gdwarf-2" should remove the comment and MOZ_DEBUG_SYMBOLS=1 as well. (elsewhere too)
Attachment #8482436 -
Flags: review?(bugspam.Callek) → review-
(In reply to Justin Wood (:Callek) from comment #1) > Comment on attachment 8482436 [details] [diff] [review] > Remove invalid / redundant options from mozconfigs > > Review of attachment 8482436 [details] [diff] [review]: > ----------------------------------------------------------------- > > r- purely because there is more stuff to do. > > ::: suite/config/mozconfigs/linux32/debug > @@ -14,4 @@ > > > > # For NSS symbols > > export MOZ_DEBUG_SYMBOLS=1 > > -ac_add_options --enable-debug-symbols="-gdwarf-2" > > should remove the comment and MOZ_DEBUG_SYMBOLS=1 as well. (elsewhere too) As both TB and IB have kept this in their in-tree mozconfig files I thought it was best to keep in sync with them. If it is definitely no longer needed then I will remove it and spin off bugs to do it in TB and IB too.
Flags: needinfo?(bugspam.Callek)
Unbitrotted, for other products I have spun off the MOZ_DEBUG_SYMBOLS question into bug 1306959
Attachment #8482436 -
Attachment is obsolete: true
Flags: needinfo?(bugspam.Callek)
Attachment #8796942 -
Flags: review?(ewong)
Attachment #8796942 -
Flags: review?(bugspam.Callek)
Comment on attachment 8796942 [details] [diff] [review] Remove invalid / redundant options from mozconfigs unbitrot [Approval Request Comment] Regression caused by (bug #): User impact if declined: build bustage Testing completed (on m-c, etc.): Risk to taking this patch (and alternatives if risky): String changes made by this patch: None
Attachment #8796942 -
Flags: approval-comm-release?
Attachment #8796942 -
Flags: approval-comm-beta?
Attachment #8796942 -
Flags: approval-comm-aurora?
Comment on attachment 8796942 [details] [diff] [review] Remove invalid / redundant options from mozconfigs unbitrot Rebased one for c-r in progress
Attachment #8796942 -
Flags: approval-comm-release?
[Approval Request Comment] Regression caused by (bug #): User impact if declined: build bustage Testing completed (on m-c, etc.): Risk to taking this patch (and alternatives if risky): String changes made by this patch: None
Attachment #8796945 -
Flags: approval-comm-release?
![]() |
||
Updated•6 years ago
|
Attachment #8796945 -
Flags: approval-comm-release? → approval-comm-release+
![]() |
||
Updated•6 years ago
|
Attachment #8796942 -
Flags: review?(ewong) → review+
![]() |
||
Comment 8•6 years ago
|
||
https://hg.mozilla.org/comm-central/rev/bd8bb475e446 https://hg.mozilla.org/releases/comm-release/rev/5e94611d6a37
status-seamonkey2.45:
--- → wontfix
status-seamonkey2.46:
--- → fixed
status-seamonkey2.47:
--- → affected
status-seamonkey2.48:
--- → affected
status-seamonkey2.49esr:
--- → fixed
Keywords: leave-open
Target Milestone: --- → seamonkey2.49
![]() |
||
Comment 9•6 years ago
|
||
Comment on attachment 8796945 [details] [diff] [review] Remove invalid / redundant options from mozconfigs for c-r in the release-l10n mozconfigs.. also need to make sure they don't have the --with-ccache option.
Comment 10•6 years ago
|
||
Comment on attachment 8796942 [details] [diff] [review] Remove invalid / redundant options from mozconfigs unbitrot Review of attachment 8796942 [details] [diff] [review]: ----------------------------------------------------------------- clearing r? since ewong reviewed. a+
Attachment #8796942 -
Flags: review?(bugspam.Callek)
Attachment #8796942 -
Flags: approval-comm-beta?
Attachment #8796942 -
Flags: approval-comm-beta+
Attachment #8796942 -
Flags: approval-comm-aurora?
Attachment #8796942 -
Flags: approval-comm-aurora+
Comment 11•6 years ago
|
||
Aurora (TB 51, SM 2.48) https://hg.mozilla.org/releases/comm-aurora/rev/c7792897153ba9fe4a26e3c9a1bb6bdff4f25e6e
Comment 12•6 years ago
|
||
Beta (TB 50, SM 2.47): https://hg.mozilla.org/releases/comm-beta/rev/15bae09243e012a9fda19d943d3ba7c1b56b7e0b
![]() |
||
Comment 13•6 years ago
|
||
I think this is fixed with the push to c-b and c-a
You need to log in
before you can comment on or make changes to this bug.
Description
•