1061448 - password, proxy and proxy port fields are not inluded in APN details

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Beatriz Rodríguez [:brg]]

Attachment: 2014-09-02-09-23-21.png

Tested with today master(2.1) Flame, Gecko-2fbbb04.Gaia-59bd661, the fields:
- Password
- HTTP proxy host
- HTTP proxy port 

are in blank while they should have the some values. see the screenshot of the issue.
The suitable values according to [1] are:
- Password: telefonica
- HTTP proxy host: 10.138.255.133
- HTTP proxy port: 8080

[1]https://github.com/mozilla-b2g/gaia/blob/master/shared/resources/apn.json#L195

Comment 1

[Arthur Chen [:arthurcc][inactive after 6/30]]

Attachment: link to https://github.com/mozilla-b2g/gaia/pull/23660

EJ, could you help check this simple patch? Thanks.

Comment 2

[Arthur Chen [:arthurcc][inactive after 6/30]]

[Blocking Requested - why for this release]: The issue prevents users from using correct APN settings.

Comment 3

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8483281 [details]
link to https://github.com/mozilla-b2g/gaia/pull/23660

Thanks for fixing this problem and we all didn't notice that ! 

r+

Comment 4

[Arthur Chen [:arthurcc][inactive after 6/30]]

Thanks!

master: 35698d531c540526d53180a4057f4d53e8a0f126

Comment 5

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8483281 [details]
link to https://github.com/mozilla-b2g/gaia/pull/23660

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Bug 1032629
[User impact] if declined: This is a critical bug. APN settings will not be set correctly
[Testing completed]: Manual and unit tests completed.
[Risk to taking this patch] (and alternatives if risky): Low
[String changes made]: None

Comment 6

[howie [:howie]]

Triage: main feature defect, blocking.

Comment 7

[Juanjo Iglesias]

I have tested it using a Flame master (Gecko d48269b ,Gaia 3a15400) and it works properly. 

When i select a APN profile from the APN list, i can see the value of the fields password, HTTP proxy host
and HTTP proxy port. 

I add a screenshot to ilustrate it.

Comment 8

[Juanjo Iglesias]

Attachment: 2014-09-05-09-10-40.png

Comment 9

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/80ef9185ca6027f2666568a7f6d1ae8bfe67c0a8

Comment 10

[Juanjo Iglesias]

I have tested it with flame 2.1 (Gecko-f816f7e Gaia-c7b55ed)and i can see the value of the fields password, HTTP proxy host and HTTP proxy port . 

I add a screenshot to ilustrate it.

Comment 11

[Juanjo Iglesias]

Attachment: APN_.png

Comment 12

[Beatriz Rodríguez [:brg]]

Bug marked as verified. Thank you all for fixing it!

Comment 13

[Mike Lien[:mlien]]

refer to comment 7, mark as 2.2 verified