Open Bug 1061456 Opened 5 years ago Updated 4 years ago

/favicon.ico doesn't work without <link rel="shortcut icon" href="…"> anymore

Categories

(Firefox :: Tabbed Browser, defect)

32 Branch
x86
Windows 7
defect
Not set

Tracking

()

UNCONFIRMED

People

(Reporter: infocatcher.bugs, Unassigned)

Details

Attachments

(1 file)

User Agent: Mozilla/5.0 (Windows NT 6.1; rv:31.0) Gecko/20100101 Firefox/31.0
Build ID: 20140716183446

Steps to reproduce:

Load any page without <link rel="shortcut icon" href="…">, but with http://site.com/favicon.ico

Example: http://habrahabr.ru/


Actual results:

Tab doesn't have icon (and created bookmsrk also doesn't have icon).
All works fine in Firefox 31 and older, but broken in 32, 33 and 34.


Expected results:

Tab should have icon.
Component: Untriaged → Tabbed Browser
Looks like at least exists problem here:
view-source:chrome://browser/content/tabbrowser.xml
      <method name="useDefaultIcon">
        <parameter name="aTab"/>
        <body>
          <![CDATA[
            ...

            // Use documentURIObject in the check for shouldLoadFavIcon so that we
            // do the right thing with about:-style error pages.  Bug 453442
            if (!icon && this.shouldLoadFavIcon(documentURI)) {
              let url = documentURI.prePath + "/favicon.ico";
              if (!this.isFailedIcon(url)) // <-- will be "!true" here
                icon = url;
            }
            this.setIcon(aTab, icon);
          ]]>
        </body>
      </method>

Test from Scratchpad (devtools.chrome.enabled = true, Environment - Browser):
gBrowser.isFailedIcon(content.document.documentURIObject.prePath + "/favicon.ico");
(In reply to Infocatcher from comment #1)
> Another example: https://forum.mozilla-russia.org/
> Icon: https://forum.mozilla-russia.org/favicon.ico

Both this and the site in comment #0 load an icon for me? (Firefox 32rc)

Did you check against a clean profile? I wonder if this is a race condition of sorts...
Flags: needinfo?(infocatcher.bugs)
(In reply to :Gijs Kruitbosch from comment #3)
> Did you check against a clean profile? I wonder if this is a race condition
> of sorts...
I already checked on a clean profile (and with disabled plugins to be really sure)…

Now I checked again:
Windows 7 x86 SP1 (this is another machine with the same OS, but I still see this bug)
Firefox 32.0 RC ftp://ftp.mozilla.org/pub/mozilla.org/firefox/releases/32.0/win32/en-US/Firefox%20Setup%2032.0.exe
+ clean profile
+ disabled (global) plugins

Ans still no favicons.

Yet another (and a bit more simple test page):
http://infocatcher.ucoz.net/test/clicks.html (test isn't about this, just page with icon)
+ http://infocatcher.ucoz.net/favicon.ico

And something strange: favicons works fine on my another development profile with latest Nightly 34.0a1 (2014-09-02).
Flags: needinfo?(infocatcher.bugs)
Attached image fx32_no_favicons.png
Oh, looks like this caused by browser.cache.disk.capacity = 0 (+ browser.cache.disk.smart_size.enabled = false)
And I used http://portableapps.com/apps/internet/firefox_portable launcher (that has a bit different defaults) to not close my main browser.
So, this is about new cache backend…
And seems like browser.cache.disk.enable = false fixes this bug for me (but strange, still buggy on one profile with latest Nightly).
I am using Cyberfox 32 (firefox 32) and can confirm that the same favicon problem is happening to me also. Changing browser.cache.disk.capacity to anything other than 0 fixes the problem.
You need to log in before you can comment on or make changes to this bug.