Closed Bug 1061500 Opened 10 years ago Closed 10 years ago

Add dividers between fields in Contacts Form screen

Categories

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Contacts
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(tracking-b2g:backlog, b2g-v2.1 fixed, b2g-v2.2 fixed)

Status:
RESOLVED FIXED
Milestone:
2.1 S5 (26sep)
Project Flags:
tracking-b2g backlog
Tracking Flags:
Tracking Status
b2g-v2.1 --- fixed
b2g-v2.2 --- fixed

People

(Reporter: sergi, Assigned: crdlc)

References

Details

(Whiteboard: P=1)

Attachments

(3 files, 2 obsolete files)

Divider_contact.png
176.71 KB, image/png
Details
divider.png
47.32 KB, image/png
fang
: ui-review+
Details
Github pull request
191 bytes, text/html
jmcf
: review+
fabrice
: approval-gaia-v2.1+
Details 
Add grey line dividers to contact edit form.
Assignee: nobody → sergi.mansilla
Whiteboard: P=1
Target Milestone: --- → 2.1 S4 (12sep)
This is a very simple, low-risk fix that improves user experience.
blocking-b2g: --- → 2.1?
triage: major issue to new feature "contacts form redesign".
Functionality-wise it works, but this fix(polish) is must-have to make the feature shiny.
blocking-b2g: 2.1? → 2.1+
Triage group reviewed - polish bugs cannot hold back an entire release from shipping. Please review the blocking criteria at https://wiki.mozilla.org/B2G/Triage#Blocker_Triage_Guidelines to understand what constitutes a blocker.

2.1 is open for approved landings, so request approval from Fabrice or Bhavana in order to land this if it's fixed in time!
blocking-b2g: 2.1+ → backlog
Target Milestone: 2.1 S4 (12sep) → 2.1 S5 (26sep)
Assignee: sergi.mansilla → jmcf
Attached file 24106.html (obsolete) — 

        Attachment #8490108 -
        Flags: review?(sergi.mansilla)

    
  

        Attachment #8490108 -
        Flags: review?(sergi.mansilla) → review?(crdlc)

    
    

    
  
Comment on attachment 8490108 [details]
24106.html

LGTM regarding to code, thanks

        Attachment #8490108 -
        Flags: review?(crdlc) → review+

    
    

    
  
Comment on attachment 8490108 [details]
24106.html

Fang, please could you have a look, thanks

        Attachment #8490108 -
        Flags: ui-review?(fshih)

    
  

        Attachment #8490108 -
        Flags: ui-review?(fshih) → ui-review-

    
    

    
  

      
      
      
      

        Attached image
          
        Divider_contact.png
        — 
      

    


  
Hi Jose,

Thanks for the update! Looks good! Can we have the divider shorter, it should leave 5 rem space from left edge. Please refer to the spec attached. And the divider color should be #e7e7e7. Thanks!

    
    

    
  

      
      
      
      

        Attached image
          
        divider.png
        — 
      

    


  
Thanks Fang

        Attachment #8491332 -
        Flags: ui-review?(fshih)

    
    

    
  

      
      
      
      

        Attached patch
          
          
        New color and padding (obsolete)
        — 
          — Splinter Review
      

    


  
Please Jose add it to your pr if the ui-review is +

    
    

    
  
Comment on attachment 8491332 [details]
divider.png

Thanks!

        Attachment #8491332 -
        Flags: ui-review?(fshih) → ui-review+

    
  

        Attachment #8490108 -
        Attachment is obsolete: true

    
  

        Attachment #8491337 -
        Attachment is obsolete: true

    
    

    
  

      
      
      
      

        Attached file
          
        Github pull request
        — 
      

    


  

        Attachment #8491413 -
        Flags: review?(jmcf)

    
    

    
  
Comment on attachment 8491413 [details]
Github pull request

thanks for fixing this

        Attachment #8491413 -
        Flags: review?(jmcf) → review+

    
    

    
  
landed in master:

https://github.com/mozilla-b2g/gaia/commit/0b631fdc11c0d8174e419fc951c5ab9263cfa00c
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED

    
    

    
  
Comment on attachment 8491413 [details]
Github pull request

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Visual refresh of Contacts
[User impact] if declined: Medium, low perceived quality
[Testing completed]: Yes and UX review is positive
[Risk to taking this patch] (and alternatives if risky): No risk patch
[String changes made]:

        Attachment #8491413 -
        Flags: approval-gaia-v2.1?

        Attachment #8491413 -
        Flags: approval-gaia-v2.1? → approval-gaia-v2.1+
blocking-b2g: backlog → ---

          tracking-b2g:
          --- → backlog

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: