1061596 - [User Story] As a helper I can add a topic to a question at any time, so that it gets added to the discussion thread metadata.

Status: VERIFIED FIXED

(support.mozilla.org :: BuddyUp, defect, P2)

Comment 1

[Romain Testard [:RT]]

Kadir, Hermina, can you please provide the list of categories?

Comment 2

[Kadir Topal [:atopal]]

I'd say that we use the current list on the desktop site. Hermina?

Comment 3

[Hermina]

I would use this apps focused list instead:

Email
Clock/Alarm
Camera/Gallery/Video
Audio/Music/RadioFM
Performance
Celular Data/WiFi/Bluetooth
SMS/MMS
Calling&Contacts
Browser/Download
Storage/SD card
HERE Maps/GPS
Keyboard
System Updates
Language
Marketplace/Apps Install
Other

Comment 4

[Anthony Ricaud (:rik)]

I'm not sure how this relates to SUMO storage. Does it mean we change the topic of the question? The current ones listed are https://support.allizom.org/en-US/products/firefox-os
Or is it another field? In terms of flow, why is it useful to have this feature?

Comment 5

[Anthony Ricaud (:rik)]

So from our standup, I gathered that we should probably store this into tags. Mike: Do we have an API for this?

Comment 6

[Michael Cooper [:mythmon]]

We don't have an API for this, and it isn't a part of the code I'm very familiar with. After a brief review of the site, it does seem like tags would be the right place to put this. We'll need to file a new bug for this, or find a work-around.

Anthony, can you file a bug for this, and make it block or not block this bug as appropriate?

Comment 7

[Kadir Topal [:atopal]]

Moving to the next sprint

Comment 8

[Anthony Ricaud (:rik)]

Jaqueline: Instead of going with a specific page for this user story, I'm thinking of just going with a <select> button. That means we get the <select> value selector for free. That means we can also easily display the current chosen topic. What do you think?

Comment 9

[Anthony Ricaud (:rik)]

Forgot needinfo for comment 8

Comment 10

[Jacqueline Savory [:jsavory] UX]

Hey Anthony, I think a value selector box would work well here. I think I was originally thinking that the category's titles would be too long, but looking at it now a value selector makes much more sense.

Comment 11

[Anthony Ricaud (:rik)]

My work in progress is at https://github.com/Rik/buddyup/tree/topics-1061596. Maybe Rehan can drive this home?

Comment 12

[Rehan Dalal (Inactive)]

Attachment: https://github.com/mozilla/buddyup/pull/82

Comment 13

[Anthony Ricaud (:rik)]

Comment on attachment 8564622 [details] [review]
https://github.com/mozilla/buddyup/pull/82

We really need to do a big s/topic/categories/ in that patch. Otherwise, it will be confusing give that we already have a topic property for a question.

I also think we don't need to have constants into Settings.js. As I suggested, the API changes to SumoDB should be the following:
- SumoDB.set_category_for_question(category, question)
  With category being 'email' (no prefix). This method will know what the prefix is but doesn't expose it.
- SumoDB.get_question(question_id) should return an object that has a category property (again, no prefix, just 'email')

This abstracts the storage implementation away from question_controller.

Comment 14

[Rehan Dalal (Inactive)]

Comment on attachment 8564622 [details] [review]
https://github.com/mozilla/buddyup/pull/82

updated as per our conversation

Comment 15

[Anthony Ricaud (:rik)]

Comment on attachment 8564622 [details] [review]
https://github.com/mozilla/buddyup/pull/82

Ship it!

Comment 16

[Rehan Dalal (Inactive)]

Landed:
https://github.com/mozilla/buddyup/commit/687bf0095c420a651ff08f5ff583f0af5ef0b0a3