Closed
Bug 1061636
Opened 11 years ago
Closed 11 years ago
Remove icons from the Cost Control widget FTU section
Categories
(Firefox OS Graveyard :: Gaia::Cost Control, defect)
Tracking
(b2g-v2.1 verified, b2g-v2.2 verified)
VERIFIED
FIXED
2.1 S5 (26sep)
People
(Reporter: gmarty, Assigned: mai)
References
Details
Attachments
(1 file)
|
46 bytes,
text/x-github-pull-request
|
salva
:
review+
fabrice
:
approval-gaia-v2.1+
|
Details | Review |
With the land of the utility tray visual refresh, we want to get rid of the icons used in the FTU section of the cost control widget to preserve consistency.
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → mri
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8489357 [details] [review]
patch v1.0
Per bug 1038723 and comment 43, let's get rid of former icons. Thank you :mai!
Attachment #8489357 -
Flags: review?(salva) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
Master: 6422de382bba5537bb0b26904df3bb70c22e5cc2
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 4•11 years ago
|
||
Comment on attachment 8489357 [details] [review]
patch v1.0
[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Bug 1061636
[User impact] if declined: No visible impact, removing unused code, that it can producing regressions on the future
[Testing completed]: Yes
[Risk to taking this patch] (and alternatives if risky): Low risk
[String changes made]: No
Attachment #8489357 -
Flags: approval-gaia-v2.1?(release-mgmt)
|
||
Updated•11 years ago
|
Attachment #8489357 -
Flags: approval-gaia-v2.1?(release-mgmt) → approval-gaia-v2.1+
|
||
Comment 5•11 years ago
|
||
|
||
Comment 6•11 years ago
|
||
Unable to verify this because this was code that was removed from the backend.
QA Whiteboard: [QAnalyst-verify-]
|
|
||
Updated•11 years ago
|
QA Whiteboard: [QAnalyst-verify-] → [QAnalyst-verify-][QAnalyst-Triage?]
Flags: needinfo?(ktucker)
|
|
||
Comment 7•11 years ago
|
||
The issue is verified fixed in Flame 2.1 and Flame 2.2:
Flame 2.1 KitKat Base (319mb)(Full Flash)
Environmental Variables:
Device: Flame 2.1
BuildID: 20141008000201
Gaia: d71f8804d7229f4b354259d5d8543c25b4796064
Gecko: 7fa82c9acdf2
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 34.0a2 (2.1)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0
Flame 2.2 KitKat Base (319mb)(Full Flash)
Environmental Variables:
Device: Flame 2.2 Master
BuildID: 20141008040203
Gaia: 0bc74ce502672cf0265b24cf3a25d117c3de5e71
Gecko: e4cfacb76830
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 35.0a1 (2.2 Master)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0
The icons are not present in the cost control widget FTU.
Status: RESOLVED → VERIFIED
QA Whiteboard: [QAnalyst-verify-][QAnalyst-Triage?] → [QAnalyst-Triage?]
|
||
Updated•11 years ago
|
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(ktucker)
You need to log in
before you can comment on or make changes to this bug.
Description
•