1061644 - crash in java.lang.IllegalArgumentException: Couldn''t find search engine for identifier: YAHOO at org.mozilla.search.providers.SearchEngineManager.createEngine(SearchEngineManager.java)

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Search Activity, defect)

Description

[Aaron Train [:aaronmt]]

This bug was filed from the Socorro interface and is 
report bp-6b3ec78c-ff2f-47c9-81d5-de3b42140901.
=============================================================

java.lang.IllegalArgumentException: Couldn't find search engine for identifier: YAHOO
	at org.mozilla.search.providers.SearchEngineManager.createEngine(SearchEngineManager.java:172)
	at org.mozilla.search.providers.SearchEngineManager.access$100(SearchEngineManager.java:27)
	at org.mozilla.search.providers.SearchEngineManager$1.doInBackground(SearchEngineManager.java:85)
	at android.os.AsyncTask$2.call(AsyncTask.java:288)
	at java.util.concurrent.FutureTask.run(FutureTask.java:237)
	at android.os.AsyncTask$SerialExecutor$1.run(AsyncTask.java:231)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1112)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:587)
	at java.lang.Thread.run(Thread.java:841)

Comment 1

[:Margaret Leibovic]

Thanks for filing. I ran into this myself over the weekend. Fix coming soon!

This also shouldn't affect Firefox 34, since the search activity is disabled there.

Comment 2

[:Margaret Leibovic]

Attachment: Fall back to default engine if engine can't be found from pref

This won't migrate the pref that a user may already have set, but this is a more robust fix that could actually fix future problems (e.g. user chooses default engine, switches locale, engine no longer exists in new locale).

As I said in the bug that caused this, I don't care about migrating Nightly users :)

Comment 3

[:Margaret Leibovic]

https://hg.mozilla.org/integration/fx-team/rev/1bbaa42b6534
https://github.com/mozilla/fennec-search/commit/1d9c0585eed88e9d7630d5d1257e6ffd5ff07b76

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/1bbaa42b6534

Comment 5

[u279076]

(In reply to Wes Kocher (:KWierso) from comment #4)
> https://hg.mozilla.org/mozilla-central/rev/1bbaa42b6534

Should this be marked status-firefox35:fixed/disabled or is affected still appropriate?

Comment 6

[:Margaret Leibovic]

(In reply to Anthony Hughes, QA Mentor (:ashughes) from comment #5)
> (In reply to Wes Kocher (:KWierso) from comment #4)
> > https://hg.mozilla.org/mozilla-central/rev/1bbaa42b6534
> 
> Should this be marked status-firefox35:fixed/disabled or is affected still
> appropriate?

This is fixed on 35.

Comment 7

[u279076]

Thanks Margaret. Verified fixed based on crash-stats.