1061660 - The transition for the overflow menu is skipped the first time it's pressed

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Browser Chrome, defect)

Description

[Chris Lord [:cwiiis]]

The first time you press the overflow menu, the transition that should happen for the menu appearing is skipped. This is a regression vs. the prettier menu and probably easily fixed, so let's get at least that amount of polish in :)

Comment 1

[Chris Lord [:cwiiis]]

Attachment: Fix missing BaseUI transitions after creation

Transitions on the first show of BaseUI elements is often missing because they end up getting created and setting the 'visible' style class doesn't count separately from the creation of the element.

This fixes the issue by forcing a style flush after creation.

This unfortunately doesn't fix all the missing transitions in the SMS app because there aren't any in that case - the element just gets created and added/removed from the DOM with no transitions.

Comment 2

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8500442 [details] [review]
Fix missing BaseUI transitions after creation

Interesting, wonder if this is a styling issue or platform issue though.

Comment 3

[Chris Lord [:cwiiis]]

Comment on attachment 8500442 [details] [review]
Fix missing BaseUI transitions after creation

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Missing transition the first time you open the browser menu
[User impact] if declined: Menu feels slightly broken/janky
[Testing completed]: Tested locally
[Risk to taking this patch] (and alternatives if risky): Pretty much no risk at all
[String changes made]: None

Comment 4

[Chris Lord [:cwiiis]]

Adding checkin-needed attachment #8500442 [details] [review] - don't know when the tree is reopening and would like to get this landed asap.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/gaia/commit/7a5de82d16215f5d49954f97e0061b6d90a9f853

Comment 6

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/3cb034ab4c884c567d39f1766ead80109bfed254