1061750 - Single Variant - Build: Generate the configuration file for bookmarks

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Carmen Jimenez Cabezas]

Generated the configuration file needed by the browser single variant configuration implemented in bug 940647 in a similar way to the rest of the single variant customizations

Comment 1

[Carmen Jimenez Cabezas]

Attachment: V1 Proposed patch

Comment 2

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Wow. So were we doing /anything/ with the gaia/customization/browser.json file? That's what I was going off of for bug 940647.

Comment 3

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

[Blocking Requested - why for this release]: Without this, bookmark customization will never load the correct file, so we'll never actually customize bookmarks.

Comment 4

[Albert [:albert]]

Comment on attachment 8482853 [details] [review]
V1 Proposed patch

Nice, thank you Carmen!

I leave a comment in github, it is just a proposal..

As I saw tbpl not launched automatically I did it for you:

https://tbpl.mozilla.org/?tree=Try&rev=be0c90bb7b53

Comment 5

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 8482853 [details] [review]
V1 Proposed patch

code looks good but we got a build error on try server but it looks an intermittent error, I have re-run it.

another thing is seem we lack some document for variant.json on MDN[1], could you also update the document?

and r=yurenju, thank you!

[1] https://developer.mozilla.org/en-US/Firefox_OS/Developing_Firefox_OS/Market_customizations_guide

Comment 6

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

https://tbpl.mozilla.org/?rev=6e4c871d1f400d422c511ca771ae26f1d5d2b2c5&tree=Gaia-Try

Comment 7

[Carmen Jimenez Cabezas]

I've retriggered the Gb job several times and one of them at least is green. 
I don't think the errors are related with this patch at all (in fact, I get errors when triggering a try run without my patch also). 
I haven't merged it yet just in case you don't want me to, but I think it should be safe to merge (at least it won't break the tests more :)). Can I merge this (or you if you wish) or do you want me to check something else before?

Comment 8

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

please land it, the root cause of red Gb has been fixed on bug 1061563, so it shoud be gone if rebase the pr.

Comment 9

[Carmen Jimenez Cabezas]

https://github.com/mozilla-b2g/gaia/commit/515e009f60a9f0ec697af61e29a4c6fa6fe15c2e

Comment 10

[Carmen Jimenez Cabezas]

Comment on attachment 8482853 [details] [review]
V1 Proposed patch

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Bug 1061804 - Browser migration operator variant followup 
[User impact] if declined: Without this, bookmark customization will never load the correct file, so we'll never actually customize bookmarks
[Testing completed]: Unit tests in gaia
[Risk to taking this patch] (and alternatives if risky): Low
[String changes made]: None

Comment 11

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/d910c0937510191047fb8e44c25b1774888ba5d4