106187 - Add "Label" as a filter action

Status: VERIFIED FIXED

(MailNews Core :: Filters, defect, P2)

Description

[scottputterman]

Now that we are doing labels we should be able to create a filter action for it.
See the spec listed in the url field for the current design.

Comment 1

[David :Bienvenu]

I'll add the backend for this and give it back to you for the front end.

Comment 2

[David :Bienvenu]

Attachment: first cut at fix

Comment 3

[David :Bienvenu]

this patch hardcodes the label strings in the filter ui, while Sean does the
prefs ui for setting the label strings.

Comment 4

[(not reading, please use [e-mail] instead)]

Comment on attachment 54710 [details] [diff] [review]
first cut at fix

sr=sspitzer

Comment 5

[Navin Gupta]

r=naving

Comment 6

[Sean Su]

Comment on attachment 54710 [details] [diff] [review]
first cut at fix

r=ssu

Comment 7

[David :Bienvenu]

reassigning to Sean to do the work to get the user's label names in the filter ui.

Comment 8

[Sean Su]

Attachment: patch to fix the labels in the filter dialog.

Comment 9

[Sean Su]

Attachment: patch v1.1 to fix the labels UI in the filters dialog.

This second patch fixes a problem of a previous labels filter info not properly
displayed on the initialization of the filters dialog.

Comment 10

[Navin Gupta]

I was just trying this out to help sean. David, it seems that you have not added
the code actually does the filtering (imap and pop3). 

Comment 11

[David :Bienvenu]

looks like I never got it reviewed or checked in. I'll attach a patch.

Comment 12

[(not reading, please use [e-mail] instead)]

can you attach a screen shot?

Comment 13

[Sean Su]

Attachment: image of filters perform action rules

thought it might look like it hasn't changed from before, it now uses the
descriptions from the prefs.

Comment 14

[Alex Bishop]

Regarding the wording 'Label the message header'... I don't think the average 
user knows or cares what a message header is. How about simply 'Label the 
message'?

Comment 15

[robinf]

Yes, I agree with Alex's suggestion: "Label the message"

Comment 16

[Sean Su]

Attachment: patch v.1.2 to fix the labels feature in filters dialog

This patch contains the wording change.

Comment 17

[(not reading, please use [e-mail] instead)]

Comment on attachment 60741 [details] [diff] [review]
patch v.1.2 to fix the labels feature in filters dialog

sr=sspitzer, looks good.

one open issue, should "None" be a filter option?  (may be useful for filtering
after the fact.)

Comment 18

[varada]

Comment on attachment 60741 [details] [diff] [review]
patch v.1.2 to fix the labels feature in filters dialog

r=varada

Comment 19

[Sean Su]

patch checked in.

Comment 20

[laurel]

Label filter action present in filter rules dialog's action list, selectable and
works when message received which matches conditions set. 
Filter action for label in and basically working. Any specific issues found with
the label filter action will be logged separately.

OK using dec13 commercial truk buuld: win98, mac OS X, linux rh6.2