Closed
Bug 1061931
Opened 10 years ago
Closed 10 years ago
[Search App] String Change: FTU search suggestion
Categories
(Firefox OS Graveyard :: Gaia::Search, defect)
Tracking
(feature-b2g:2.1, ux-b2g:2.1, b2g-v2.1 verified, b2g-v2.2 verified)
People
(Reporter: swilkes, Assigned: kgrandon)
References
Details
(Keywords: late-l10n, Whiteboard: [systemsfe])
Attachments
(2 files)
46 bytes,
text/x-github-pull-request
|
Pike
:
review+
bajaj
:
approval-gaia-v2.1+
|
Details | Review |
7.32 MB,
video/mp4
|
Details |
FTU search suggestion needs a new string. Francis to provide in order to make 9/2 string freeze deadline.
Reporter | ||
Updated•10 years ago
|
feature-b2g: --- → 2.1
ux-b2g: --- → 2.1
Comment 1•10 years ago
|
||
When typing in the search app for the first time, the user is shown the following message in a pop-up:
"Search suggestions are shown as you type. Go to the Homescreen section of Settings to change your search preferences".
The search suggestions now have their own section in settings for 2.1. We also got feedback that the string was not informative enough to users re: privacy. Please change the string to:
"The characters you type are sent to multiple search providers and are used to send you search suggestions. Go to the Search section of Settings to change your search preferences".
Comment 2•10 years ago
|
||
(In reply to Stephany Wilkes from comment #0)
> FTU search suggestion needs a new string. Francis to provide in order to
> make 9/2 string freeze deadline.
Hey guys...is there a reason why this is coming in so late for 2.1?
Assignee | ||
Comment 3•10 years ago
|
||
(In reply to Candice Serran (:cserran) from comment #2)
> Hey guys...is there a reason why this is coming in so late for 2.1?
It seems like we missed tracking some work to update this in 2.1. We had implemented this in 2.0 for the previous settings panel implementation, but it seems that we forgot to track this with a bug when doing the settings panel movement.
Assignee: nobody → kgrandon
Status: NEW → ASSIGNED
Whiteboard: [systemsfe]
Target Milestone: --- → 2.1 S4 (12sep)
Assignee | ||
Comment 4•10 years ago
|
||
Comment 5•10 years ago
|
||
I'm not sure how this relates to branch mechanics for 2.1 today, so flagging this as late-l10n.
I'd like a localization note referencing that "Search" and "Settings" are app names.
Keywords: late-l10n
Comment 6•10 years ago
|
||
doh, wrong pike again.
Comment 7•10 years ago
|
||
Just reviewed this on device with Kevin and the string looked over-long, so we decided to shorten this to:
"The characters you type are used to show you search suggestions. Go to the Search section of Settings to change your search preferences".
Assignee | ||
Comment 8•10 years ago
|
||
Comment on attachment 8483040 [details] [review]
Github pull request
Axel - Would you be willing/able to review this since it might be late l10n and to see if you're happy with the localization note? Thanks!
Attachment #8483040 -
Flags: review?(l10n)
Assignee | ||
Updated•10 years ago
|
Blocks: rocketbar-mvp
Comment 9•10 years ago
|
||
Comment on attachment 8483040 [details] [review]
Github pull request
Technically, and copy-wise, this seems to be OK.
Given that this is post the 2.1 branch changeset, this will need approval in its own right, my review doesn't make a statement on its branch-worthiness.
PPS: I'm not really a gaia reviewer, but this patch is close enough to l10n-only that I don't think it's worth sending you off for a another review.
Attachment #8483040 -
Flags: review?(l10n) → review+
Assignee | ||
Comment 10•10 years ago
|
||
Comment on attachment 8483040 [details] [review]
Github pull request
We would like to uplift this to 2.1.
[Bug caused by] (feature/regressing bug #): Missed feature scope.
[User impact] if declined: An invalid notice will be displayed to the user (This feature was changed in the Settings app, but the notice was never updated)
[Testing completed]: Manual verification and UI-review with Francis
[Risk to taking this patch] (and alternatives if risky): It's l10n only so low risk.
[String changes made]: Yes, added a new string in the Search app.
Attachment #8483040 -
Flags: approval-gaia-v2.1?(bbajaj)
Assignee | ||
Comment 11•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Updated•10 years ago
|
Attachment #8483040 -
Flags: approval-gaia-v2.1?(bbajaj) → approval-gaia-v2.1+
Comment 12•10 years ago
|
||
status-b2g-v2.1:
--- → fixed
status-b2g-v2.2:
--- → fixed
Updated•10 years ago
|
Component: Gaia::L10n → Gaia::Search
Comment 13•10 years ago
|
||
This issue has been verified successfully on Flame2.1&2.2
Verify video:"verify_1061931.mp4".
Flame2.1 build:
Gaia-Rev ccb49abe412c978a4045f0c75abff534372716c4
Gecko-Rev https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/18fb67530b22
Build-ID 20141202001201
Version 34.0
Device-Name flame
FW-Release 4.4.2
FW-Incremental eng.cltbld.20141202.034824
FW-Date Tue Dec 2 03:48:34 EST 2014
Bootloader L1TC00011880
Flame2.2 bulid:
Gaia-Rev 725685831f5336cf007e36d9a812aad689604695
Gecko-Rev https://hg.mozilla.org/mozilla-central/rev/2c9781c3e9b5
Build-ID 20141202040207
Version 37.0a1
Device-Name flame
FW-Release 4.4.2
FW-Incremental eng.cltbld.20141202.072347
FW-Date Tue Dec 2 07:23:58 EST 2014
Bootloader L1TC00011880
Comment 14•10 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•