1061941 - [Contacts] Editing visible information (name) is not reflected in 'Contacts' until page/app refreshes for newly created contacts

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Oliver Nelson [:oliverthor]]

Attachment: logcat_20140902_1415_newContacts_SlowRefresh.txt

Description:
When user creates a new contact, their visible information will display on the "Contact Details" and "Contacts List" pages. When the user then updates visible information without having closed the app between creating/editing (Contact Details Visible: Name, Picture, Phone, Email, Company, Carrier, Address, Date, Comment || Contacts List Visible: Name, Picture), their visible information will not be updated until the page is refreshed (Contact Details) or the app is restarted (Contacts List). The UI elements will maintain the previous entries (or lack thereof) until they reach a point to be refreshed as called by the 'Contacts' app, not added to persistent refresh list.

Repro Steps:
1) Update a Flame device to BuildID: 20140902040205
2) Open 'Contacts' app.
3) Create new contact with some fields: first name, last name, picture and phone number.
4) Observe how new contact displays itself in "Contact Details" and "Contacts List" visibly.
3) Enter "Contact Details" for above contact and perform an edit to change fields: first name, last name, picture and phone number.
4) Update changes and observe(1) Contact Details page of changed fields: first name, last name, picture and phone number.
5) Close "Contacts Details" to move back to "Contacts List".
6) Observe(2) edited contact's visible information: first name, last name and picture.
  
Actual:
After editing:
(1) "Contacts Details" fields for first name, last name, picture and phone number retain old values visibly until page is closed and reopened.
(2) "Contacts List" contact entry for edited user retains previous values (first name, last name and picture) until App is refreshed.
  
Expected: 
After editing:
(1) "Contacts Details" visible fields reflect edited entries (first name, last name, picture, phone number).
(2) "Contacts List" contact entry visible fields reflect edited entries (first name, last name, picture).
  

Environmental Variables:
Device: Flame 2.1 Master (319mb)
BuildID: 20140902040205
Gaia: 44bf2e3bc5ddea9db9a8c851bd353cb234aa883c
Gecko: c360f3d1c00d
Version: 34.0a1 (2.1 Master)
Firmware: V123
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0
  

Repro frequency: 5/5 - 100%
See attached: (screenshot, video clip, logcat, etc.)
logcat
video- http://youtu.be/4_co3iTzEzQ

Comment 1

[Oliver Nelson [:oliverthor]]

This issue does NOT occur in Flame 2.0
User is able to edit Contacts and have visible information be reflected immediately.

Environmental Variables:
Device: Flame 2.0
BuildID: 20140902000202
Gaia: 449d8db9b3ea1f9262db822c37ef2143477172b7
Gecko: 40d74e0bbcf5
Version: 32.0 (2.0) 
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Comment 2

[Peter Bylenga [:PBylenga]]

[Blocking Requested - why for this release]:
This is a bad user experience, user aren't seeing the results of their changes immediately.

Requesting a window.

Comment 3

[Francisco Jordano [:arcturus] [:francisco]]

Hei Sergi,

we probably caused this regression with the new contacts redesign.

Comment 4

[Chris Kreinbring [:CKreinbring]]

Regression window
Last working
BuildID: 20140830094116
Gaia: c05ee27dd1f39e0f1cceb8bc7706e20f297cd9df
Gecko: 82e1c0a8c589
Platform Version: 34.0a1
Firmware Version: V123
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0

First broken
BuildID: 20140830195315
Gaia: 2be78d83a760fa3b9638fe51c266b442d14597f1
Gecko: 1db35d2c9a2f
Platform Version: 34.0a1
Firmware Version: V123
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0

Working Gaia / Broken Gecko = No repro
Gaia: c05ee27dd1f39e0f1cceb8bc7706e20f297cd9df
Gecko: 1db35d2c9a2f
Broken Gaia / Working Gecko = Repro
Gaia: 2be78d83a760fa3b9638fe51c266b442d14597f1
Gecko: 82e1c0a8c589
Gaia pushlog: https://github.com/mozilla-b2g/gaia/compare/c05ee27dd1f39e0f1cceb8bc7706e20f297cd9df...2be78d83a760fa3b9638fe51c266b442d14597f1


B2G inbound
Last working
BuildID: 20140829112301
Gaia: c05ee27dd1f39e0f1cceb8bc7706e20f297cd9df
Gecko: 7d956b954dd7
Platform Version: 34.0a1
Firmware Version: V123
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0

First broken
BuildID: 20140829113200
Gaia: 4419091ae760328a52606920e335331a16fcb448
Gecko: 3748d4065959
Platform Version: 34.0a1
Firmware Version: V123
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0

Working Gaia / Broken Gecko = No repro
Gaia: c05ee27dd1f39e0f1cceb8bc7706e20f297cd9df
Gecko: 3748d4065959
Broken Gaia / Working Gecko = Repro
Gaia: 4419091ae760328a52606920e335331a16fcb448
Gecko: 7d956b954dd7
Gaia pushlog: https://github.com/mozilla-b2g/gaia/compare/c05ee27dd1f39e0f1cceb8bc7706e20f297cd9df...4419091ae760328a52606920e335331a16fcb448

Comment 5

[Joshua Mitchell (Inactive)]

Broken by Bug 1042591 Francisco?

Comment 6

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

triage: identifiable regression

Comment 8

[Maria Angeles Oteo (:oteo)]

Bug 1062768 seems to be also a duplicated of this bug, so when trying to delete a contact from the contact details screen, that contact is not removed immediately. I need to close and open Contacts app again to see that contact removed from the Contact list.

Comment 10

[Adrián de la Rosa]

Attachment: Pull request #23902

I just added two characters. You just forgot to call a parameter, no big deal ;)

Comment 11

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

Thanks! Merged at 109ebe515b10e5c3257ecfc24b3e8aa62773a169

Comment 12

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8487088 [details]
Pull request #23902

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
Feature, contact form redesign
[User impact] if declined:
Huge, user will need to restart contacts app to see changes applied to the list
[Testing completed]:
Smoke test passed
[Risk to taking this patch] (and alternatives if risky):
Low risk, oneliner, we missed a parameter.
[String changes made]:

Comment 14

[Loli (:lolimartinezcr)]

Tested and working
Flame
2.2
Gecko-52f8689
Gaia-d61264c

Pending 2.1

Comment 15

[bhavana bajaj [:bajaj]]

Comment on attachment 8487088 [details]
Pull request #23902

Given the number of DUP's and this is a bad regression which we definitely want to fix, approving for 2.1

Comment 16

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/5dffc00ca1769919689253c722ea224dff27bb27

Comment 17

[Loli (:lolimartinezcr)]

Tested and working
2.1
Flame
Gecko-713c41b
Gaia-32d82d2

Comment 18

[Sue]

Attachment: video of issue verify

This issue has been successfully verified on Flame 2.1
See attachment: verify_video.MP4
Reproducing rate: 0/5
Flame 2.1 versions:
Gaia-Rev        1b231b87aad384842dfc79614b2a9ca68a4b4ff3
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/95fbd7635152
Build-ID        20141119001205
Version         34.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141119.035246
FW-Date         Wed Nov 19 03:52:56 EST 2014
Bootloader      L1TC00011880