1061947 - Avoid flushing layout and making it dirty repeatedly in ToolbarIconColor.inferFromText

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Dão Gottwald [:dao]]

Attachment: patch

Preliminary testing suggests that this cuts off about half of the performance regression filed as bug 1015572.

Comment 1

[:Gijs (he/him)]

Comment on attachment 8483037 [details] [diff] [review]
patch

Review of attachment 8483037 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me

I wondered (but didn't check) if we could save the remainder of the perf impact here by persisting the attribute. As it's a tpaint regression and we'll measure the first window, we should have it right from the get-go for all the successive windows. I would expect the theme to not change frequently, so I think this should be a net win "in the real world", too.

Comment 2

[Dão Gottwald [:dao]]

https://hg.mozilla.org/integration/fx-team/rev/ee2ad2a64c1e

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ee2ad2a64c1e

Comment 4

[Dão Gottwald [:dao]]

Comment on attachment 8483037 [details] [diff] [review]
patch

Approval Request Comment
[Feature/regressing bug #]: bug 1012629
[User impact if declined]: a startup performance regression
[Describe test coverage new/current, TBPL]: not covered by tests
[Risks and why]: pretty simple and very isolated fix, not risky
[String/UUID change made/needed]: none

Comment 5

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8483037 [details] [diff] [review]
patch

I like perf fixes. Especially those that have been on m-c for a week without know bustage. Beta+ and Aurora+

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/d1f86b92be8d
https://hg.mozilla.org/releases/mozilla-beta/rev/2938d6cea847