Closed Bug 1061949 Opened 10 years ago Closed 9 years ago

Bookmark star in context menu should use same tooltip as bookmark star in toolbar

Categories

(Firefox :: Menus, defect)

Product:
Firefox
Component:
Menus
Version:
32 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: mathew.hodson, Assigned: jaws)

References

Details

(Whiteboard: [fixed by bug 777680]) 

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:32.0) Gecko/20100101 Firefox/32.0
Build ID: 20140830210550

Steps to reproduce:

The new bookmark star in the context menu has a different tooltip than the one in the toolbar. The two stars should always have the exact same tooltip. The other context menu buttons have consistent tooltips.


Actual results:

The tooltip for the context menu star is "Bookmark This Page"


Expected results:

The tooltip should be "Bookmark this page (Ctrl+D)"
Component: Untriaged → Menus
Blocks: 1000513
Hardware: x86_64 → All
Whiteboard: [good first bug]
I'd like to be assigned to this bug. someone assign me please.
No longer blocks: 1000513
Status: UNCONFIRMED → RESOLVED
Closed: 9 years ago
Resolution: --- → DUPLICATE
This isn't a duplicate of bug 777680. This bug is about changing the text "Bookmark This Page" to "Bookmark this page (Ctrl+D)"

This bug isn't about indicating whether the current page is in your bookmarks, and that work doesn't need to be completed to resolve this bug.
Status: RESOLVED → UNCONFIRMED
Resolution: DUPLICATE → ---
Blocks: 1000513
Blocks: 777680
Assignee: nobody → amila.efac
This is fixed by the patch in bug 777680 which just landed on fx-team.
Assignee: amila.efac → jaws
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Whiteboard: [good first bug] → [fixed by bug 777680]
Status: ASSIGNED → RESOLVED
Closed: 9 years ago → 9 years ago
Resolution: --- → FIXED
OS: Linux → All
The tooltip is now correctly implemented, for both states (bookmarked/not bookmarked) of a page.
Tested on Windows 7 32-bit, Windows 10 64-bit, Mac OS X 10.9.5 and Ubuntu 14.04 64-bit using Firefox 40.0b1, build ID: 20150811185633.
Status: RESOLVED → VERIFIED
No longer blocks: 777680
Depends on: 777680
You need to log in before you can comment on or make changes to this bug.