1061961 - ScriptSourceObject::initFromOptions calls skipped

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jim Blandy :jimb]

Attachment: Fully initialize ScriptSourceObjects built by XDR and for Function.prototype.

SpiderMonkey fails to call ScriptSourceObject::initFromOptions on ScriptSourceObjects created for XDR and for Function.prototype's script.

Comment 1

[Jim Blandy :jimb]

Try:
https://tbpl.mozilla.org/?tree=Try&rev=4d07635b5dc0

Comment 2

[Jim Blandy :jimb]

Comment on attachment 8483067 [details] [diff] [review]
Fully initialize ScriptSourceObjects built by XDR and for Function.prototype.

Switching reviewers, as Shu was involved in the conversation and has already looked at the patch a bit.

Comment 3

[Shu-yu Guo [:shu]]

Comment on attachment 8483067 [details] [diff] [review]
Fully initialize ScriptSourceObjects built by XDR and for Function.prototype.

Review of attachment 8483067 [details] [diff] [review]:
-----------------------------------------------------------------

The fix looks fine to me.

IIUC, the only reason SourceScriptObject::create doesn't also initialize itself with options is because of off-thread parsing. How do you feel about removing create in favor of createWithOptions and createFromOffThread to make it harder to simply forget to initialize? No need to block landing this fix for the refactor though.

Comment 4

[Jim Blandy :jimb]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d052bb1a13b8

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d052bb1a13b8