1062048 - Intermittent failing test, TEST-UNEXPECTED-FAIL | /builds/slave/test/gaia/apps/calendar/test/marionette/day_view_test.js | day view "before each" hook

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Calendar, defect)

Description

[Evan Tseng [:evanxd]]

TEST-UNEXPECTED-FAIL | /builds/slave/test/gaia/apps/calendar/test/marionette/day_view_test.js | day view "before each" hook

16:54:16     INFO -    1) day view "before each" hook:
16:54:16     INFO -    ElementNotVisible: (11) Element is not visible
16:54:16     INFO -    Remote Stack:
16:54:16     INFO -    <none>
16:54:16     INFO -        at Error.MarionetteError (/builds/slave/test/gaia/node_modules/marionette-client/lib/marionette/error.js:67:13)
16:54:16     INFO -        at Object.Client._handleCallback (/builds/slave/test/gaia/node_modules/marionette-client/lib/marionette/client.js:476:19)
16:54:16     INFO -        at /builds/slave/test/gaia/node_modules/marionette-client/lib/marionette/client.js:510:21
16:54:16     INFO -        at TcpSync.send (/builds/slave/test/gaia/node_modules/marionette-client/lib/marionette/drivers/tcp-sync.js:153:10)
16:54:16     INFO -        at Object.send (/builds/slave/test/gaia/node_modules/marionette-client/lib/marionette/client.js:457:36)
16:54:16     INFO -        at Object.Client._sendCommand (/builds/slave/test/gaia/node_modules/marionette-client/lib/marionette/client.js:503:19)
16:54:16     INFO -        at Object.Element._sendCommand (/builds/slave/test/gaia/node_modules/marionette-client/lib/marionette/element.js:49:21)
16:54:16     INFO -        at Object.click (/builds/slave/test/gaia/node_modules/marionette-client/lib/marionette/element.js:176:19)
16:54:16     INFO -        at Object.Calendar.launch (/builds/slave/test/gaia/apps/calendar/test/marionette/lib/calendar.js:49:12)
16:54:16     INFO -        at Context.<anonymous> (/builds/slave/test/gaia/apps/calendar/test/marionette/day_view_test.js:23:9)
16:54:16     INFO -        at callFn (/builds/slave/test/gaia/node_modules/mocha/lib/runnable.js:223:21)
16:54:16     INFO -        at Hook.Runnable.run (/builds/slave/test/gaia/node_modules/mocha/lib/runnable.js:216:7)
16:54:16     INFO -        at next (/builds/slave/test/gaia/node_modules/mocha/lib/runner.js:258:10)
16:54:16     INFO -        at /builds/slave/test/gaia/node_modules/mocha/lib/runner.js:270:7
16:54:16     INFO -        at done (/builds/slave/test/gaia/node_modules/mocha/lib/runnable.js:185:5)
16:54:16     INFO -        at /builds/slave/test/gaia/node_modules/mocha/lib/runnable.js:199:9
16:54:16     INFO -        at Object.executeHook (/builds/slave/test/gaia/node_modules/marionette-client/lib/marionette/client.js:369:18)
16:54:16     INFO -        at process._tickCallback (node.js:415:13)

[1] https://tbpl.mozilla.org/php/getParsedLog.php?id=47264476&tree=Gaia-Try#error0

Comment 1

[Ed Morley [:emorley]]

Adding keyword so this shows in TBPL's bug suggestions list.

Comment 2

[Kevin Grandon :kgrandon]

It seems this test fails daily between the hours of 12:00 and 1:00 due to the time format.

TEST-UNEXPECTED-FAIL | /builds/slave/test/gaia/apps/calendar/test/marionette/day_view_test.js | day view 12/24 hour format default format: 12 hour
Bug 1062048 - Intermittent failing test, TEST-UNEXPECTED-FAIL | /builds/slave/test/gaia/apps/calendar/test/marionette/day_view_test.js | day view "before each" hook AssertionError: expected '12:44' to equal '0:44'
make: *** [test-integration-test] Error 1

Comment 3

[Kevin Grandon :kgrandon]

Attachment: Pull request - Part 1 - Fix 12hr formatting at 12:00

I think this should fix the issue.

Comment 4

[Kevin Grandon :kgrandon]

Comment on attachment 8489162 [details] [review]
Pull request - Part 1 - Fix 12hr formatting at 12:00

Evan - wondering if you can review this for me. This fixes at least one very common problem with day_view test which is starred against this bug.

I haven't seen the originally reported problem here recently, but I think we should land this fix first in this bug, and continue to monitor it. Thanks!

Comment 5

[Kevin Grandon :kgrandon]

Comment on attachment 8489162 [details] [review]
Pull request - Part 1 - Fix 12hr formatting at 12:00

This is simple and test only, so I'm going to land with r=me. If there's any concerns or suggestions for this first part, let me know and we'll address them.

I think this test is still intermittent, but this should solve a lot of the problems that we're seeing.

Comment 6

[Kevin Grandon :kgrandon]

First part in master: https://github.com/mozilla-b2g/gaia/commit/d54d86834495fc60d5dca63d7f7f841a87efa329

Comment 7

[Evan Tseng [:evanxd]]

Thanks for Kevin's help.
I was busy working on https://github.com/evanxd/marionette-hardware yesterday, sorry for having no time to review it.

Comment 8

[Kevin Grandon :kgrandon]

There is yet another failure that's starred against this bug: 1) day view 12/24 hour format default format: 12 hour:
13:31:40     INFO -    AssertionError: expected '' to equal '1 PM'
13:31:40     INFO -        at Context.<anonymous> (/builds/slave/test/gaia/apps/calendar/test/marionette/day_view_test.js:297:14)
13:31:40     INFO -        at callFn (/builds/slave/test/gaia/node_modules/mocha/lib/runnable.js:223:21)
13:31:40     INFO -        at Test.Runnable.run (/builds/slave/test/gaia/node_modules/mocha/lib/runnable.js:216:7)
13:31:40     INFO -        at Runner.runTest (/builds/slave/test/gaia/node_modules/mocha/lib/runner.js:373:10)
13:31:40     INFO -        at /builds/slave/test/gaia/node_modules/mocha/lib/runner.js:451:12
13:31:40     INFO -        at next (/builds/slave/test/gaia/node_modules/mocha/lib/runner.js:298:14)
13:31:40     INFO -        at /builds/slave/test/gaia/node_modules/mocha/lib/runner.js:308:7
13:31:40     INFO -        at next (/builds/slave/test/gaia/node_modules/mocha/lib/runner.js:246:23)
13:31:40     INFO -        at Object._onImmediate (/builds/slave/test/gaia/node_modules/mocha/lib/runner.js:275:5)
13:31:40     INFO -        at processImmediate [as _immediateCallback] (timers.js:330:15)
13:31:40     INFO -    2) day view 12/24 hour format switch to 24 hour format:

Seems like it's the same thing, we're probably not calculating 12 hour formats correctly.

Comment 9

[Kevin Grandon :kgrandon]

Attachment: Pull Request - Part 2 - Use waitFor after changing settings

Comment 10

[Kevin Grandon :kgrandon]

Comment on attachment 8492430 [details] [review]
Pull Request - Part 2 - Use waitFor after changing settings

Adding a simple wait due to the async nature of settings. Going to R=me on this one.

Comment 11

[Kevin Grandon :kgrandon]

In master: https://github.com/mozilla-b2g/gaia/commit/87ebeb4966af84ff7e305d8b9c04f7be6b01244b

Since we have had a few patches for this test, and it's still starred, in order to get a more refreshed stack I'm going to suggest that we close this out and open a new bug if we see more issues with this test.