1062053 - [TSF] nsTextStore should use StaticRefPtr

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.1 nsTextStore should use StaticRefPtr for storing COM objects

This makes all static members storing COM objects StaticRefPtr.

In the future, we should move nsTextStore into mozilla::widget namespace for getting rid of the redundant "mozilla::" in nsTextStore.h. However, if we do so now, it breaks my patches which needs to be landed as soon as possible. Therefore, I'll do it later.

And this patch removes Tsf prefix from the static variables because it's very clear that it's related to TSF in nsTextStore.

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.2 Rename nsTextStore::sTsfClientId to nsTextStore::sClientId

And also this renames the sTsfClientId to sClientId for consistency with other static member names.

Comment 3

[Masatoshi Kimura [:emk]]

Comment on attachment 8483368 [details] [diff] [review]
part.1 nsTextStore should use StaticRefPtr for storing COM objects

>+  static_assert(false,
>+    "GetNativeData() returns pointer to StaticRefPtr<>, fix here for it");

How can this work? Did we already stop compiling TestWinTSF.cpp?

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to Masatoshi Kimura [:emk] from comment #3)
> Comment on attachment 8483368 [details] [diff] [review]
> part.1 nsTextStore should use StaticRefPtr for storing COM objects
> 
> >+  static_assert(false,
> >+    "GetNativeData() returns pointer to StaticRefPtr<>, fix here for it");
> 
> How can this work? Did we already stop compiling TestWinTSF.cpp?

Yes. IIRC, it's disabled due to wrong string API usage. Anyway, the test won't pass with current nsTextStore because the test just checks the behavior of first nsTextStore implementation. In other words, the test assumes that the old implementation is the "correct" implementation as ITextStore.

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ad0c990e9fdc
https://hg.mozilla.org/integration/mozilla-inbound/rev/47d2dd4ecad1

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ad0c990e9fdc
https://hg.mozilla.org/mozilla-central/rev/47d2dd4ecad1