106206 - keyword: and data: protocol handlers should be moved to necko2

Status: VERIFIED FIXED

(Core :: Networking, defect, P3)

Description

[Stuart Parmenter]

After running mozilla for a while under purecoverage (ran jrgm's tests, etc), I
see us not using the data protocol handler or the keyword protocol handler.  I
recommend we move that code in to necko2.  During my run, necko2 was never
loaded.

Comment 1

[Christopher Hoess (gone)]

*** This bug has been marked as a duplicate of 98753 ***

Comment 2

[Darin Fisher]

nope, this is not a dupe of bug 98753... that is something related but different.

Comment 3

[Darin Fisher]

-> 0.9.9

Comment 4

[Darin Fisher]

-> 1.0

Comment 5

[Darin Fisher]

easy to fix, but not critical -> moz 1.1

Comment 6

[Marcia Knous [:marcia]]

EDT Triage (chofmann et al) - will pick this change up if it becomes available. 

Comment 7

[Darin Fisher]

mass futuring of untargeted bugs

Comment 8

[Alec Flett]

I might take this. For now just adding it to my list.

Comment 9

[benc]

following the conversation in 98753 about what procotols are needed.

data: is increasingly popular, and we are receiving a steady set of bugs asking
for it to work correctly. It is also described in RFCs, so I think that

keyword: is not described in an RFC, is proprietary, and the original design
goals  are still not well understood (at least by me and anyone I've asked about
it).

(current docs are http://www.mozilla.org/docs/end-user/internet-keywords.html,
I'll be updating it soon w/ a more user-oriented guide).

Until we understand more about how vendors want their keyword/search systems to
work, I'm not confident keyword: works the way they need it to.

Comment 10

[Alec Flett]

Attachment: move data and keyword into necko2

Here's the patch. who wants to review? this is easy stuff, mostly just makefile
changes... on my release build, this moves 4k of optimized code from necko.dll
to necko2.dll.

Comment 11

[Alec Flett]

Comment on attachment 112189 [details] [diff] [review]
move data and keyword into necko2

Sorry for more 1.3b reviews, but this is an easy one - just moving stuff around
to save some footprint on embedding.

Comment 12

[Darin Fisher]

Comment on attachment 112189 [details] [diff] [review]
move data and keyword into necko2

sr=darin

Comment 13

[Alec Flett]

over to me

Comment 14

[Alec Flett]

fix is in.

Comment 15

[benc]

alecf: do you have cvs checkin output or a bonzai query that can show the
checkin? if so, you can verify this yourself. If not, I'll get to this when I
get a chance.

Comment 16

[Alec Flett]

http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=alecf%25netscape.com&whotype=match&sortby=Date&hours=2&date=week&mindate=&maxdate=&cvsroot=%2Fcvsroot

Comment 17

[benc]

VEFIFIED:

Comment 18

[Mike Ruskai]

The data protocol should be put back into the embedding build.  Taking it out
breaks the ActiveX control, and seriously breaks its functionality in my
application (which uses the data protocol exclusively).

Comment 19

[benc]

Mike: I dont' know anything about ActiveX, but I'm going to assume it is
important :)

I recommend you create a NEW bug, and describe this dependency, so that the
right people can think about un-moving data: if needed.

Since this bug is fixed, I'd like to leave it that way.

Comment 20

[Ashish Bhatt]

The active-X control uses a data url as its default url when its created. It is
used to display title of the control when it is put on a design form ( Visual
Basic). I am not sure if this will prevent the active-x control from loading.

CCing Adam Lock on this

Comment 21

[Adam Lock]

Yes, the ActiveX control uses it. There is bug 189230 for the issue already
which affects the view-source protocol too.