1062092 - Context menu search (with default search engine) does not work in the content area of a message compose or SM-Composer window

Status: RESOLVED FIXED

(SeaMonkey :: Search, defect)

Description

[mozillastuff]

User Agent: Mozilla/5.0 (Windows NT 5.1; rv:29.0) Gecko/20100101 Firefox/29.0 SeaMonkey/2.26.1
Build ID: 20140612174402

Steps to reproduce:

compose new msg
highlight some text
right click search [searchengine] for "some text"


Actual results:

nothing


Expected results:

open browser page with search results

Comment 1

[therube]

Confirmed.
I would have expected there to be a bug on this already, but I'm not finding anything. (May have just missed it?)

Expect that ever since there was a context-menu item, "Search ___ for ___" that this bug has existed? Composer affected likewise.

> Error: ReferenceError: BrowserSearch is not defined
> Source File: chrome://editor/content/editor.xul
> Line: 1

Comment 2

[Philip Chee]

>> Error: ReferenceError: BrowserSearch is not defined
>> Source File: chrome://editor/content/editor.xul
>> Line: 1
The error probably comes from: contentAreaContextOverlay.xul
http://mxr.mozilla.org/comm-central/source/suite/common/contentAreaContextOverlay.xul?rev=9cf4459806ca&mark=264-265#264

> 264 <menuitem id="context-searchselect"
> 265 oncommand="BrowserSearch.loadSearch(gContextMenu.searchSelected(), true, event);"/>

Comment 3

[Rainer Bielefeld]

Same problem in SeaMonkey Composer (what might be the core of the problem?)

Comment 4

[Ian Neal]

Attachment: 1062092-context-searchselect-25321.patch

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: unable to use context web search in composer / message compose
Testing completed (on m-c, etc.): 2.53.21pre
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none

This patch:

• Adds searchEngine helper to nsContextMenu.js for is TextSelection to use as well as the new openSearch function
• Moves MsgOpenSearch from mailWindowOverlay.js to nsContextMenu.js as the new openSearch function
• Makes all context web search menuitems use the new openSearch function
• Removes the now unused code in BrowserSearch.loadSearch

Comment 5

[Ian Neal]

Attachment: 1062092-context-searchselect-v1_1-25321.patch

Extra braces

Comment 6

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9466452 [details] [diff] [review]
1062092-context-searchselect-v1_1-25321.patch

LGTM r/a+

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/3783f2eb5cd8
Context menu search (with default search engine) does not work in the content area of a message compose or SM-Composer window. r=frg DONTBUILD

Comment 8

[Frank-Rainer Grahl (:frg)]

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/7ee30a5b6bfab1eefc631161dd23a9b0b8392cd5
Context menu search (with default search engine) does not work in the content area of a message compose or SM-Composer window. r=frg a=frg