1062098 - VideoToolbox: Attempt to display dropped frame

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Jean-Yves Avenard [:jya]]

The AppleVTDecoder will attempt to output a dropped frame, when there are nothing to output.

From https://bugzilla.mozilla.org/show_bug.cgi?id=1059066#c11

Comment 1

[Jean-Yves Avenard [:jya]]

Attachment: Do not attempt to output dropped frames

Don't attempt to output dropped frames. There's nothing to output

Comment 2

[Ralph Giles (:rillian)]

Comment on attachment 8483327 [details] [diff] [review]
Do not attempt to output dropped frames

Review of attachment 8483327 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, and good catch.

Comment 3

[Ralph Giles (:rillian)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/746180e3801c

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/746180e3801c

Comment 5

[Ryan VanderMeulen [:RyanVM]]

This was backed out in bug 1063255.

Comment 7

[Jean-Yves Avenard [:jya]]

Attachment: Do not attempt to display dropped frames

don't display dropped frame v2: we force the call to request more data when the task queue is empty. Should prevent issue seen in bug 1063255.

Comment 8

[Jean-Yves Avenard [:jya]]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/c7f0bac9cad8

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c7f0bac9cad8

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/f953bfcccb9c