1062248 - Change styles of notifications when battery is low

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Manuel Casas Barrado [:mancas]]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:32.0) Gecko/20100101 Firefox/32.0
Build ID: 20140830210659

Steps to reproduce:

Have low battery


Actual results:

When battery low notification is displayed, the text is not showed inside the notification


Expected results:

the text is shown properly

Comment 1

[Manuel Casas Barrado [:mancas]]

Attachment: Changed styles of low battery notification

Comment 2

[Manuel Casas Barrado [:mancas]]

Attachment: Notification styles

Comment 3

[Manuel Casas Barrado [:mancas]]

Attachment: notification_fail.png

Comment 4

[Maria Angeles Oteo (:oteo)]

[Blocking Requested - why for this release]: As Bug 1046202 (Copy improvement when battery is almost empty), which introduced this regression, was landed in 2.1, we need to fix the issue also in 2.1 branch.

Comment 5

[Jenny Lee]

Comment on attachment 8483435 [details]
Notification styles

Looks good, but I think we need Eric for styling review just in case. Thanks!

Comment 6

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8483432 [details] [review]
Changed styles of low battery notification

Why did it failed?

Comment 7

[Manuel Casas Barrado [:mancas]]

The main problem was that the width of the container was not defined, so when the text overflows, the block jumps to the next line to fit the text

Comment 8

[Eric Pang [:epang] UX]

(In reply to Jenny Lee from comment #5)
> Comment on attachment 8483435 [details]
> Notification styles
> 
> Looks good, but I think we need Eric for styling review just in case. Thanks!

Thanks Jenny for flagging me, we've updated the styling of notification toast for 2.1.  I'll add a spec with the new styling shortly. I will also need to create a new icon and get review for it first.  flagging  need info on myself so I don't forget to add the spec to the bug when ready.

Comment 9

[Eric Pang [:epang] UX]

Comment on attachment 8483435 [details]
Notification styles

Sorry I was thinking this was a notification instead of a system toast.  This looks good to me, thanks! R+

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/gaia/commit/494db904b78a271601d9d4be79ee0a7313518de7

Please request Gaia v2.1 approval on this when you get a chance.

Comment 11

[Manuel Casas Barrado [:mancas]]

Comment on attachment 8483435 [details]
Notification styles

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):1046202
[User impact] if declined: Hight impact, text is not displayed properly
[Testing completed]: No
[Risk to taking this patch] (and alternatives if risky): Low
[String changes made]: Yes

Comment 12

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/08c3a9c8efdc4a5ab771ac4217c757249bde77de

Comment 13

[Juanjo Iglesias]

I have tested it using a flame 2.1 (Gecko f816f7e Gaia c7b55ed).

The text of the alert has been modified correcly and the alert is working fine. 

When the battery level is below a 10% of the charge, now the alert message is "Your battery is low. Please plug in your charger".

I add a screenshot to ilustrate it.

Comment 14

[Juanjo Iglesias]

Attachment: 2014-09-10-21-02-39.png

Comment 15

[Beatriz Rodríguez [:brg]]

Thanks for fixing it. Bug marked as verified!

Comment 16

[Kevin Grandon :kgrandon]

Minor copy changes, don't need an integration test for this.

Comment 17

[Elie]

Attachment: 2014-11-20-16-30-21[1].png

This issue has been successfully verified on Flame 2.1:
Gaia-Rev        1b231b87aad384842dfc79614b2a9ca68a4b4ff3
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/95fbd7635152
Build-ID        20141119001205
Version         34.0
Device-Name     flame
FW-Release      4.4.2