Closed
Bug 1062250
Opened 10 years ago
Closed 10 years ago
UI is using the wrong get_resultset_jobs endpoint URI causing 301 redirects
Categories
(Tree Management :: Treeherder, defect, P2)
Tree Management
Treeherder
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: emorley, Assigned: emorley)
Details
(Keywords: perf)
Attachments
(1 file)
|
6.85 KB,
patch
|
jeads
:
review+
|
Details | Diff | Splinter Review |
13:04:40.824 GET https://treeherder.mozilla.org/api/project/mozilla-central/resultset/1/get_resultset_jobs [HTTP/1.1 301 MOVED PERMANENTLY 176ms] 13:04:40.825 GET https://treeherder.mozilla.org/api/project/mozilla-central/resultset/1/get_resultset_jobs [HTTP/1.1 301 MOVED PERMANENTLY 179ms] 13:04:40.826 GET https://treeherder.mozilla.org/api/project/mozilla-central/resultset/1/get_resultset_jobs [HTTP/1.1 301 MOVED PERMANENTLY 179ms] 13:04:40.826 GET https://treeherder.mozilla.org/api/project/mozilla-central/resultset/1/get_resultset_jobs [HTTP/1.1 301 MOVED PERMANENTLY 306ms] 13:04:40.827 GET https://treeherder.mozilla.org/api/project/mozilla-central/resultset/1/get_resultset_jobs [HTTP/1.1 301 MOVED PERMANENTLY 305ms] 13:04:40.828 GET https://treeherder.mozilla.org/api/project/mozilla-central/resultset/1/get_resultset_jobs [HTTP/1.1 301 MOVED PERMANENTLY 306ms] 13:04:40.828 GET https://treeherder.mozilla.org/api/project/mozilla-central/resultset/1/get_resultset_jobs [HTTP/1.1 301 MOVED PERMANENTLY 353ms] 13:04:40.829 GET https://treeherder.mozilla.org/api/project/mozilla-central/resultset/1/get_resultset_jobs [HTTP/1.1 301 MOVED PERMANENTLY 356ms] 13:04:40.829 GET https://treeherder.mozilla.org/api/project/mozilla-central/resultset/1/get_resultset_jobs [HTTP/1.1 301 MOVED PERMANENTLY 360ms] 13:04:40.830 GET https://treeherder.mozilla.org/api/project/mozilla-central/resultset/1/get_resultset_jobs [HTTP/1.1 301 MOVED PERMANENTLY 485ms] Is missing the trailing slash.
|
Assignee | |
Comment 2•10 years ago
|
||
If the network graph is to be believed, should save a few hundred milliseconds from pageload.
Attachment #8483455 -
Flags: review?(jeads)
|
|
Assignee | |
Updated•10 years ago
|
Priority: -- → P3
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8483455 [details] [diff] [review] Use correct get_resultset_jobs endpoint to avoid 301 redirects Nice catch. The new "/" will definitely save some time.
Attachment #8483455 -
Flags: review?(jeads) → review+
|
|
Assignee | |
Comment 4•10 years ago
|
||
https://github.com/mozilla/treeherder-ui/commit/4aae85426507b6787a184b95bbe907038785bdd7
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
|
||
Comment 5•9 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/6a1402d239c2772794f03e9ed248d4cf15062eda Bug 1062250 - Use correct get_resultset_jobs endpoint to avoid 301 redirects
You need to log in
before you can comment on or make changes to this bug.
Description
•