1062253 - Exception calling callback: TypeError: this._backgroundUpdateCheckCodePing is not a function @ nsUpdateService.js:2380:8

Status: VERIFIED FIXED

(Toolkit :: Application Update, defect)

Description

[Georg Fritzsche [:gfritzsche]]

I happened to see this in my browser console

1409745211633	addons.manager	WARN	Exception calling callback: TypeError: this._backgroundUpdateCheckCodePing is not a function (resource://gre/components/nsUpdateService.js:2380:8) JS Stack trace: 
AUS__checkAddonCompatibility/<@nsUpdateService.js:2380:9
< [e-mail]:168:5
< [e-mail]:2061:9
< [e-mail]:263:7
< [e-mail]:2056:11
< [e-mail]:1057:5
< [e-mail]:194:12
< [e-mail]:2053:1
< [e-mail]:269:7
< [e-mail]:2056:11
< this.Experiments.PreviousExperimentProvider.prototype<[e-mail]:2302:5
< [e-mail]:194:12
< [e-mail]:2053:1
< [e-mail]:269:7
< [e-mail]:2056:11
< [e-mail]:148:5
< [e-mail]:194:12
< [e-mail]:2053:1
< [e-mail]:269:7
< [e-mail]:2056:11
< [e-mail]:344:5
< [e-mail]:194:12
< [e-mail]:2053:1
< [e-mail]:269:7
< [e-mail]:2056:11
< [e-mail]:390:5
< [e-mail]:194:12
< [e-mail]:2053:1
< [e-mail]:269:7
< [e-mail]:2056:11
< [e-mail]:3689:7
< makeSafe/<@XPIProviderUtils.js:146:17
< [e-mail]:181:7
< [e-mail]:188:9
< [e-mail]:135:5
< [e-mail]:580:7
< this.AddonRepository.getCachedAddonByID<@AddonRepository.jsm:592:5
< [e-mail]:314:40
< [e-mail]:275:3
< createAsyncFunction/[e-mail]:249:14
< [e-mail]:137:3
< [e-mail]:187:7
< [e-mail]:185:3
< this.XPIDatabase.getAddonList/<@XPIProviderUtils.js:1071:9
< [e-mail]:865:23
< [e-mail]:744:7

Comment 1

[[e-mail]]

Nearby code:

else {
  LOG("UpdateService:_checkAddonCompatibility - no incompatible " +
      "add-ons found, just download the update");
  var status = self.downloadUpdate(self._update, true);
  if (status == STATE_NONE)
    cleanupActiveUpdate();
  self._update = null;
  this._backgroundUpdateCheckCodePing(PING_BGUC_CHECK_NO_INCOMPAT);
}

Should probably be self instead of this.

Problem also affects ESR31.

Comment 2

[Robert Strong (they/them - no direct email)]

Attachment: patch

Comment 3

[Robert Strong (they/them - no direct email)]

Pushed to mozilla-inbound
https://hg.mozilla.org/integration/mozilla-inbound/rev/6049b08ce1d2

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6049b08ce1d2

Comment 5

[Robert Strong (they/them - no direct email)]

Comment on attachment 8562351 [details] [diff] [review]
patch

Approval Request Comment
[Feature/regressing bug #]: Bug 886545
[User impact if declined]: This is in support of telemetry for understanding update orphaning which is an engineering goal
[Describe test coverage new/current, TreeHerder]: Manually tested.
[Risks and why]: minimal
[String/UUID change made/needed]: None

Comment 6

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8562351 [details] [diff] [review]
patch

Can this be verified by QE? Taking it for aurora at least.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/38875c75fbb2

Comment 8

[Robert Strong (they/them - no direct email)]

(In reply to Sylvestre Ledru [:sylvestre] from comment #6)
> Comment on attachment 8562351 [details] [diff] [review]
> patch
> 
> Can this be verified by QE? Taking it for aurora at least.
I can provide steps for QE verification

Comment 9

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8562351 [details] [diff] [review]
patch

Indeed, it would be nice if you could provide some step to QE (especially for the esr version). thanks

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr31/rev/32eb65b72ab8

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/694d627b4786

Comment 12

[Robert Strong (they/them - no direct email)]

Attachment: test add-on

Comment 13

[Robert Strong (they/them - no direct email)]

Using an aurora build that is from prior to this patch landing on February 12th open about:config and set the app.update.log pref to true, app.update.enabled pref to false and the devtools.errorconsole.enabled pref to true.
Install the add-on attach to this bug by opening about:addons and dragging the link to the attachment to the about:addons tab's content window.

Check for updates (do not install) and find the entry that starts with "AUS:SVC Checker:getUpdateURL - update URL: " in the error console. Create a reference to the url. See below for an example url I got for aurora.
https://aus4.mozilla.org/update/3/Firefox/37.0a2/20150211004833/WINNT_x86-msvc/en-US/aurora/Windows_NT%206.3.0.0%20(x64)/default/default/update.xml

Create a new pref with the name app.update.url.override and a string value with the url you got previously.
In about:config set the app.update.enabled pref to true

In the error console run
const Ci = Components.interfaces; const Cc = Components.classes; Cc["@mozilla.org/updates/update-service;1"].getService(Ci.nsIApplicationUpdateService).QueryInterface(Ci.nsITimerCallback).notify(null);

You should see a message that contains the following in the error console
addons.manager	WARN	Exception calling callback: TypeError: this._backgroundUpdateCheckCodePing is not a function (resource://gre/components/nsUpdateService.js:2695:8) JS Stack trace:

Finish the update and restart

In the error console run
const Ci = Components.interfaces; const Cc = Components.classes; Cc["@mozilla.org/updates/update-service;1"].getService(Ci.nsIApplicationUpdateService).QueryInterface(Ci.nsITimerCallback).notify(null);

You should no longer see a message that contains the following in the error console
addons.manager	WARN	Exception calling callback: TypeError: this._backgroundUpdateCheckCodePing is not a function (resource://gre/components/nsUpdateService.js:2695:8) JS Stack trace:

Comment 14

[Robert Strong (they/them - no direct email)]

Note: the same process can be used for all channels when they have an update to a version that contains this fix.

Comment 15

[Robert Strong (they/them - no direct email)]

Kamil, would you be willing to verify this bug?

Comment 16

[Robert Strong (they/them - no direct email)]

I forgot a couple of steps

Using an aurora build that is from prior to this patch landing on February
12th open about:config and set the app.update.log pref to true,
app.update.enabled pref to false and the devtools.errorconsole.enabled pref
to true.
Install the add-on attach to this bug by opening about:addons and dragging
the link to the attachment to the about:addons tab's content window.

Check for updates (do not install) and find the entry that starts with
"AUS:SVC Checker:getUpdateURL - update URL: " in the error console. Create a
reference to the url. See below for an example url I got for aurora.
https://aus4.mozilla.org/update/3/Firefox/37.0a2/20150211004833/WINNT_x86-
msvc/en-US/aurora/Windows_NT%206.3.0.0%20(x64)/default/default/update.xml

Save the xml file and modify it as follows
displayVersion="39.0" appVersion="39.0" platformVersion="39.0"

Place the xml file on a web server.

Create a new pref with the name app.update.url.override and a string value
with the url to the new xml file.
In about:config set the app.update.enabled pref to true

In the error console run
const Ci = Components.interfaces; const Cc = Components.classes; Cc["@mozilla.org/updates/update-service;1"].getService(Ci.nsIApplicationUpdateService).QueryInterface(Ci.nsITimerCallback).notify(null);

You should see a message that contains the following in the error console
addons.manager	WARN	Exception calling callback: TypeError: this._backgroundUpdateCheckCodePing is not a function (resource://gre/components/nsUpdateService.js:2695:8) JS Stack trace:

Finish the update and restart

In the error console run
const Ci = Components.interfaces; const Cc = Components.classes; Cc["@mozilla.org/updates/update-service;1"].getService(Ci.nsIApplicationUpdateService).QueryInterface(Ci.nsITimerCallback).notify(null);

You should no longer see a message that contains the following in the error console
addons.manager	WARN	Exception calling callback: TypeError: this._backgroundUpdateCheckCodePing is not a function (resource://gre/components/nsUpdateService.js:2695:8) JS Stack trace:

Comment 17

[Robert Strong (they/them - no direct email)]

Also, if the update.xml has a <patch type="partial" block remove it.

Comment 18

[Kamil Jozwiak [:kjozwiak]]

Thanks for the steps Robert!! Here are the results, looks like everything is working correctly:

Nightly: PASSED
========
Build Used: http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2015-02-11-03-02-28-mozilla-central/

* received the error mentioned in comment # 16 in the error console
** 1424284506610 addons.manager WARN Exception calling callback: TypeError: this._backgroundUpdateCheckCodePing is not a function (resource://gre/components/nsUpdateService.js:2695:8)
* Updated/Restarted and ensured that the same error wasn't appearing the second time around
* went through the test case twice and got the same results

Aurora: PASSED
=======
* Build Used: http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2015-02-11-00-48-33-mozilla-aurora/

* received the error mentioned in comment # 16 in the error console
** 1424283732945 addons.manager WARN Exception calling callback: TypeError: this._backgroundUpdateCheckCodePing is not a function (resource://gre/components/nsUpdateService.js:2695:8)
* Updated/Restarted and ensured that the same error wasn't appearing the second time around
* went through the test case twice and got the same results

BETA: PASSED
=====
Build Used: http://ftp.mozilla.org/pub/mozilla.org/firefox/candidates/36.0b8-candidates/build1/

* received the error mentioned in comment # 16 in the error console
** 1424287447277 addons.manager WARN Exception calling callback: TypeError: this._backgroundUpdateCheckCodePing is not a function (resource://gre/components/nsUpdateService.js:2689:8)
* Updated/Restarted and ensured that the same error wasn't appearing the second time around
* went through the test case twice and got the same results

ESR: PASSED
====
Build Used: http://ftp.mozilla.org/pub/mozilla.org/firefox/candidates/31.4.0esr-candidates/build1/win32/en-US/

* received the error mentioned in comment # 16 in the error console
** 1424288473851 addons.manager WARN Exception calling callback: TypeError: this._backgroundUpdateCheckCodePing is not a function (resource://gre/components/nsUpdateService.js:2635:8)
* Updated/Restarted and ensured that the same error wasn't appearing the second time around
* went through the test case twice and got the same results
* changed the channel-pref to "esr-localtest"