1062259 - OpenH264 plugin is not installing on Firefox 33b1, 34.0a2 and 35.0a1

Status: RESOLVED WORKSFORME

(AUS Graveyard :: General, defect)

Description

[Ada [:adalucinet]]

Reproducible on:
Firefox 33 beta 1 (BuildID: 20140902214533):
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:33.0) Gecko/20100101 Firefox/33.0
latest Aurora 34.0a2 (Build ID: 20140903004002):
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:34.0) Gecko/20100101 Firefox/34.0
latest Nightly 35.0a1 (Build ID: 20140902121319):
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:35.0) Gecko/20100101 Firefox/35.0

STR:
1. Launch Firefox.
2. Go to Add-ons Manager -> Plugins and wait for openH264 plugin to install.

Expected results: OpenH264 plugin is installed.

Actual results: OpenH264 plugin is not installed. The “Will be installed shortly” message is displayed.

Notes:
1. Reproducible also on Windows 7 64-bit and Ubuntu 12.04 32-bit.
2. Logs: https://pastebin.mozilla.org/6292542

Comment 1

[Georg Fritzsche [:gfritzsche]]

Note that the update.xml in the log above contains is empty, so this seems to be a server-side issue:
https://aus4.mozilla.org/update/3/GMP/33.0/20140902214533/Darwin_x86_64-gcc3-u-i386-x86_64/en-US/beta/Darwin%2013.3.0/default/default/update.xml

Comment 2

[Maire Reavy [:mreavy]]

Also needinfo'ing catlee since I think bhearsum gets involved with openh264 server issues when catlee is unavailable.

(Also, adding Ethan to the cc just so we knows we're aware of the server issue.)

Comment 3

[Chris AtLee [:catlee]]

We need to adjust some version numbers after all the uplifts yesterday. Ben will get to this shortly.

Comment 4

[[e-mail] (:bhearsum)]

This should be fixed now, and also includes the new plugin from bug 1061808.

Comment 5

[Benjamin Smedberg]

Will changes of this sort be required before every uplift, or is this a special case? Otherwise we should make this part of the uplift checklist in some form.

Comment 6

[[e-mail] (:bhearsum)]

(In reply to Benjamin Smedberg  [:bsmedberg] from comment #5)
> Will changes of this sort be required before every uplift, or is this a
> special case? Otherwise we should make this part of the uplift checklist in
> some form.

I don't know yet. It depends in part of the outcome of bug 1021021. It also depends on how plugin versions track. Ie, do we serve them based on incoming version, or channel? There's still a question of how we serve the right plugin version for builds of the same version+channel but different buildids.

Comment 7

[Georg Fritzsche [:gfritzsche]]

(In reply to Ben Hearsum [:bhearsum] from comment #4)
> This should be fixed now, and also includes the new plugin from bug 1061808.

I just saw this scroll by:
> 1409754176270	GMPInstallManager.GMPDownloader._verifyDownload	INFO	_verifyDownload called
> 1409754176270	GMPInstallManager.GMPDownloader._verifyDownload	INFO	for path: /Users/gfritzsche/Library/Caches/TemporaryItems/gmp-gmpopenh264.zip
> 1409754176273	GMPInstallManager.GMPDownloader._verifyDownload	WARN	hashes do not match! Got: `37db5840f9de507bb76866659598184337745eb0242ecad4924cf7e5764e3a243dae77beba6f040420fddf2cacaa9d56ae3ca9519404508aaec55233e1970cfc`, expected: `37db5840f9de507bb76866659598184337745eb0242ecad4924cf7e5764e3a243dae77beba6f040420fddf2cacaa9d56ae3ca9519404508aaec55233e1970cf`

Did you update the hashes?

Comment 8

[[e-mail] (:bhearsum)]

(In reply to Georg Fritzsche [:gfritzsche] from comment #7)
> (In reply to Ben Hearsum [:bhearsum] from comment #4)
> > This should be fixed now, and also includes the new plugin from bug 1061808.
> 
> I just saw this scroll by:
> > 1409754176270	GMPInstallManager.GMPDownloader._verifyDownload	INFO	_verifyDownload called
> > 1409754176270	GMPInstallManager.GMPDownloader._verifyDownload	INFO	for path: /Users/gfritzsche/Library/Caches/TemporaryItems/gmp-gmpopenh264.zip
> > 1409754176273	GMPInstallManager.GMPDownloader._verifyDownload	WARN	hashes do not match! Got: `37db5840f9de507bb76866659598184337745eb0242ecad4924cf7e5764e3a243dae77beba6f040420fddf2cacaa9d56ae3ca9519404508aaec55233e1970cfc`, expected: `37db5840f9de507bb76866659598184337745eb0242ecad4924cf7e5764e3a243dae77beba6f040420fddf2cacaa9d56ae3ca9519404508aaec55233e1970cf`
> 
> Did you update the hashes?

Yes, but it looks like I mispasted some that one. Try again?

Comment 9

[Georg Fritzsche [:gfritzsche]]

Yes, works fine now.

However, i got an empty update.xml for an older nightly i was using for something else:
https://aus4.mozilla.org/update/3/GMP/34.0a1/20140810030204/Darwin_x86_64-gcc3-u-i386-x86_64/en-US/nightly/Darwin%2013.3.0/default/default/update.xml

Do we want to support that? I think we'll run into pain points with regression hunting otherwise.

Comment 10

[[e-mail] (:bhearsum)]

(In reply to Georg Fritzsche [:gfritzsche] from comment #9)
> Yes, works fine now.
> 
> However, i got an empty update.xml for an older nightly i was using for
> something else:
> https://aus4.mozilla.org/update/3/GMP/34.0a1/20140810030204/Darwin_x86_64-
> gcc3-u-i386-x86_64/en-US/nightly/Darwin%2013.3.0/default/default/update.xml
> 
> Do we want to support that? I think we'll run into pain points with
> regression hunting otherwise.

Unless there's an urgent need, I'm not going to address this until bug 1021021 is fixed.

Comment 11

[Ada [:adalucinet]]

Verified fixed on Firefox 33 beta 1 (Build ID: 20140902214533), latest Nightly 35.0a1 (Build ID: 20140903030206) and Aurora 34.0a2 (Build ID: 20140903004002) on the following platforms:  Mac OS X 10.9.4, Windows 7 64-bit, Windows 8.1 32-bit, Ubuntu 12.04 32-bit and 14.04 64-bit.