1062338 - Regression: Back button icon missing in menu on some small screen (?) hardware (?) devices

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aaron Train [:aaronmt]]

Attachment: screenshot.png

Yikes. This has been missing for quite some time apparently on some devices running Android 4.0?

This is reproducible on my Samsung S-B5330 small screen device.

  ro.build.id=JZO54K
  ro.build.display.id=JZO54K.B5330LUBUBMC2
  ro.build.version.incremental=B5330LUBUBMC2
  ro.build.version.sdk=16
  ro.build.version.codename=REL
  ro.build.version.release=4.1.2
  ro.product.model=GT-B5330L

See screenshot.

The functionality is still there, the icon is missing. The hardware back button on the keyboard works. The button still works in the menu.

Last good revision: 862cb6a1cc88 (2013-12-18)
First bad revision: 5c7fa2bfea8b (2013-12-19)
Pushlog:

http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=862cb6a1cc88&tochange=5c7fa2bfea8b

My guess is one of these 

90699ba761fb	Sriram Ramasubramanian — Bug 940997: Remove icons from main menu. [r=mfinkle]

63cac76f5f7f	Sriram Ramasubramanian — Bug 940997: Support showAsAction "ifRoom" in custom menu. [r=mfinkle]

0e84f8ba1333	Sriram Ramasubramanian — Bug 940997: Reorganize primary controls in main menu. [r=mfinkle]

Comment 1

[Aaron Train [:aaronmt]]

Attachment: historic-menu.png

History screenshot 

What the old menu used to look like prior to the changes in the above bugs.

Comment 2

[Aaron Train [:aaronmt]]

Device this is filed against has a hardware keyboard: http://www.samsung.com/latin_en/support/model/GT-B5330ZKLTTT

Comment 3

[Aaron Train [:aaronmt]]

>   ro.build.version.release=4.1.2

Forgot, I updated the device. Reflecting summary change.

Comment 4

[Aaron Train [:aaronmt]]

The device is a 320x240 LDPI device. Perhaps there's no provided drawable ic_menu_back.png?

Comment 5

[Lucas Rocha (:lucasr)]

(In reply to Aaron Train [:aaronmt] from comment #4)
> The device is a 320x240 LDPI device. Perhaps there's no provided drawable
> ic_menu_back.png?

We don't provide ldpi drawables for anything. But I'd expect android to just use mdpi (or hdpi even) in this case.

Comment 6

[Aaron Train [:aaronmt]]

Would it help if there a way for me to find the drawables in use from a hierarchy view dump? How would I do that?

Comment 7

[Lucas Rocha (:lucasr)]

(In reply to Aaron Train [:aaronmt] from comment #6)
> Would it help if there a way for me to find the drawables in use from a
> hierarchy view dump? How would I do that?

What about tinting the drawable images with different colours and seeing which one is displayed in the UI? :-)

Comment 8

[Michael Comella (:mcomella) [NI reported issues only; no longer employed by Mozilla]]

Does this work, Aaron? https://people.mozilla.org/~mcomella/apks/mcomella-1062338_01.apk

Comment 9

[Aaron Train [:aaronmt]]

(In reply to Michael Comella (:mcomella) from comment #8)
> Does this work, Aaron?
> https://people.mozilla.org/~mcomella/apks/mcomella-1062338_01.apk

Yep! I see the back button now in this build.

Comment 10

[Michael Comella (:mcomella) [NI reported issues only; no longer employed by Mozilla]]

Attachment: Remove useless ic_menu_back drawable xml

Comment 11

[Michael Comella (:mcomella) [NI reported issues only; no longer employed by Mozilla]]

https://hg.mozilla.org/integration/fx-team/rev/6ba92c715ffe

Comment 12

[Michael Comella (:mcomella) [NI reported issues only; no longer employed by Mozilla]]

Comment on attachment 8487364 [details] [diff] [review]
Remove useless ic_menu_back drawable xml

Approval Request Comment
[Feature/regressing bug #]: Unknown

[User impact if declined]:
  Users on a small subset of devices (some Android 4.0?) cannot see the back button in the options menu. Note that back is still accessible (and more highly discoverable) via the back button, but it looks really unpolished.

[Describe test coverage new/current, TBPL]:
  None

[Risks and why]: 
  Low risk - we are removing an essentially unused drawable file, which allows the image drawables already in the tree to be used by all devices.

[String/UUID change made/needed]: None

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6ba92c715ffe

Comment 14

[Lawrence Mandel [:lmandel] (use needinfo)]

Aaron - As the reporter, can you verify that this is fixed in the latest nightly build?

Comment 15

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8487364 [details] [diff] [review]
Remove useless ic_menu_back drawable xml

Thanks Aaron!

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/33771884957a
https://hg.mozilla.org/releases/mozilla-beta/rev/1c636d0e8ec1