Closed
Bug 1062388
Opened 10 years ago
Closed 9 years ago
Add add-on signed status to FHR
Categories
(Toolkit :: Add-ons Manager, defect, P5)
Toolkit
Add-ons Manager
Tracking
()
RESOLVED
FIXED
mozilla41
Tracking | Status | |
---|---|---|
firefox41 | --- | fixed |
People
(Reporter: mossop, Assigned: mossop)
References
Details
(Whiteboard: [hijacking][fxsearch])
Attachments
(1 file)
11.57 KB,
patch
|
vladan
:
review+
gfritzsche
:
review+
|
Details | Diff | Splinter Review |
Report whether add-ons are signed or not in FHR (this overlaps a little with bug 1062386 perhaps).
Assignee | ||
Updated•10 years ago
|
Assignee | ||
Updated•10 years ago
|
Flags: firefox-backlog+
Updated•10 years ago
|
Flags: qe-verify?
Updated•9 years ago
|
Points: --- → 2
Assignee | ||
Updated•9 years ago
|
Comment 1•9 years ago
|
||
Benjamin, would that be relevant to add in the Environment addon data?
Flags: needinfo?(benjamin)
Assignee | ||
Comment 2•9 years ago
|
||
Bug 1038068 adds a "signedState" property to add-ons that we'd like to show up in reporting so we can understand how much of the add-on population has been updated to signed add-ons.
Comment 3•9 years ago
|
||
Yes, this would be in the environment block of unified telemetry.
Flags: needinfo?(benjamin)
Assignee | ||
Updated•9 years ago
|
Whiteboard: [fxsearch][searchhijacking]
Assignee | ||
Updated•9 years ago
|
Priority: -- → P5
Updated•9 years ago
|
Whiteboard: [fxsearch][searchhijacking] → [hijacking][fxsearch]
Updated•9 years ago
|
Rank: 55
Assignee | ||
Comment 4•9 years ago
|
||
This adds signedState to the active add-ons in the environment and adds a signed add-on to test it. I found some weirdness in the test, test_addonsAndPlugins technically isn't checking the environment with the newly installed add-on as it isn't waiting for the environment to update so for test_signedAddon I had to add a change listener. One issue that might need to be addressed is that we don't check signing for services and so internally they have a signedState of undefined, I don't know if the server will complain about that when all the other values are numeric. We could normalize undefined to some other number, 0 is SIGNEDSTATE_MISSING but I think I'd rather use a unique number to mean "we didn't check". Let me know what you'd prefer. Spinning this through try now to double check but it passes all tests locally and I don't think there is any reason to expect this to cause more failures. We'd like to land this a.s.a.p. as we have need of this data to verify that add-on signing on AMO is working as expected.
Assignee: nobody → dtownsend
Status: NEW → ASSIGNED
Attachment #8613064 -
Flags: review?(vdjeric)
Attachment #8613064 -
Flags: review?(gfritzsche)
Comment 5•9 years ago
|
||
Comment on attachment 8613064 [details] [diff] [review] patch Review of attachment 8613064 [details] [diff] [review]: ----------------------------------------------------------------- r+ for data collection review
Attachment #8613064 -
Flags: review?(vdjeric) → review+
Assignee | ||
Updated•9 years ago
|
Attachment #8613064 -
Flags: review?(gfritzsche) → review?(alessio.placitelli)
Comment 6•9 years ago
|
||
Mossop: btw, I noticed in about:telemetry that addons already have a "-signed" suffix in their version string. Is that enough?
Flags: needinfo?(dtownsend)
Assignee | ||
Comment 7•9 years ago
|
||
(In reply to Vladan Djeric (:vladan) -- please needinfo! from comment #6) > Mossop: btw, I noticed in about:telemetry that addons already have a > "-signed" suffix in their version string. Is that enough? No this is only a temporary thing that exists for add-ons that are already on AMO. New add-ons uploaded to AMO won't have -signed in their version string.
Flags: needinfo?(dtownsend)
Comment 8•9 years ago
|
||
Comment on attachment 8613064 [details] [diff] [review] patch Review of attachment 8613064 [details] [diff] [review]: ----------------------------------------------------------------- ::: toolkit/components/telemetry/TelemetryEnvironment.jsm @@ +503,5 @@ > foreignInstall: addon.foreignInstall, > hasBinaryComponents: addon.hasBinaryComponents, > installDay: truncateToDays(installDate.getTime()), > updateDay: truncateToDays(updateDate.getTime()), > + signedState: addon.signedState, It would be clearer if we only explicitly add this property if |addon.signedState != undefined|. ::: toolkit/components/telemetry/docs/environment.rst @@ +144,5 @@ > foreignInstall: <bool>, > hasBinaryComponents: <bool> > installDay: <number>, // days since UNIX epoch, 0 on failure > updateDay: <number>, // days since UNIX epoch, 0 on failure > + signedState: <integer> or undefined, // whether the add-on is signed by AMO JSON.stringify drops any properties with value undefined, so the outgoing data never has this. I think we should just document it as being present only for type "extension" (?).
Attachment #8613064 -
Flags: review?(alessio.placitelli) → review+
https://hg.mozilla.org/mozilla-central/rev/3c6c755707d5
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox41:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in
before you can comment on or make changes to this bug.
Description
•