1062455 - add spicedham to vendor/

Status: RESOLVED FIXED

(Input Graveyard :: Backend, defect)

Description

[Will Kahn-Greene [:willkg] ET needinfo? me]

In order to use the spicedham classifier library, we must first put it in vendor/.


Note: This is purely for the purposes of integrating the spicedham prototype. We're not trying to design infrastructure that will be used outside of this specific need. After we figure out how things should work, it's expected we'll wipe away all this stuff and "start over".

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

We're going to want to add this to vendor/src/ which is all git submodules. Relevant instructions are here:

http://fjord.readthedocs.org/en/latest/vendor.html#adding-a-new-library-with-git-submodules

Pretty much this just covers adding it to vendor/. After we add it to vendor/, then we can implement the rest of the bits (which needs a new bug).

Assigning this to Ian to do the honors!

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

In a PR: https://github.com/mozilla/fjord/pull/345

Landed in master: https://github.com/mozilla/fjord/commit/7aa29300852416ad7ae84623fcd36062efb1468f

Waiting to push this until Monday.

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

Pushed this to prod last night.

Plus Ian fixed the requirements file to match.