1062462 - [Flame] SIM service provider is displayed as unknown in settings

Status: VERIFIED FIXED

(Firefox OS Graveyard :: RIL, defect)

Description

[Marcela Oniga]

Attachment: 2014-09-03-21-12-54.png

OS version: 2.2.0
Build identifier: 20140903072057
Platform version: 35.0a1

Steps to reproduce:
1. Go to settings and select device information
2. Under Phone number check sim service provider

Expected results:
Sim service provider should be properly displayed.

Actual results:
SIM service provider is displayed as unknown in settings, please see the attached screenshot.

Comment 1

[Marcela Oniga]

Reproducible on latest 2.1 too.

Gaia   a47ecb6368c015dd72148acde26413fd90ba3136
SourceStamp 757931d0149e
BuildID 20140904000203
Version 34.0a2
2.1 Aurora

Comment 2

[Pi Wei Cheng [:piwei] (inactive)]

I'm seeing this issue on today's 3.0 nightly, but not on v2.2. I tried factory resetting the phone, rebooting, switching to another SIM, and I can't seem to find a way to fix it.

Issue reproduces on:
Device: Flame 3.0 Master (full flashed, 319MB memory, KK, nightly production build)
BuildID: 20150415095209
Gaia: 2dd89fef4fae4d86fd313037ef384086c2e0e8a5
Gecko: 11077895df62
Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b
Version: 40.0a1 (3.0 Master) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:40.0) Gecko/40.0 Firefox/40.0

Issue does NOT reproduce on:
Device: Flame 2.2 (full flashed, 319MB memory, KK, nightly production build)
BuildID: 20150415002502
Gaia: 0b2e2f7c022554d57bf2afed36ba6788249197dd
Gecko: 2356b82e9a50
Gonk: ebad7da532429a6f5efadc00bf6ad8a41288a429
Version: 37.0 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

NI Kevin for triaging.

Comment 3

[KTucker [:KTucker][Inactive 3/4/2016]]

Adding qawanted for a full branch check.

Comment 4

[Pi Wei Cheng [:piwei] (inactive)]

This does NOT reproduce on v2.1 and does NOT reproduce on v2.0. All tests done on nightly production builds with full flash.

Device: Flame 2.1
BuildID: 20150415001211
Gaia: bbe983b4e8bebfec26b3726b79568a22d667223c
Gecko: 3e3cbe35bce3
Gonk: ebad7da532429a6f5efadc00bf6ad8a41288a429
Version: 34.0 (2.1) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Device: Flame 2.0
BuildID: 20150415000204
Gaia: 84898cadf28b1a1fcd03b726cff658de470282f0
Gecko: de92ad41847a
Gonk: ebad7da532429a6f5efadc00bf6ad8a41288a429
Version: 32.0 (2.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Comment 5

[KTucker [:KTucker][Inactive 3/4/2016]]

Blocking Requested - why for this release]:

From an end user's perspective this is kind of important. Some people don't know their number and will go to more information to look this up. Nominating this 3.0?

Comment 6

[Pi Wei Cheng [:piwei] (inactive)]

b2g-inbound regression window:

Last Working
Device: Flame
BuildID: 20150327085843
Gaia: 0e7c8ade48129b3e03c5de8ae0452fd1f756535c
Gecko: ce7408061848
Version: 39.0a1 (3.0 Master)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0

First Broken
Device: Flame
BuildID: 20150327090639
Gaia: 0e7c8ade48129b3e03c5de8ae0452fd1f756535c
Gecko: 174750113959
Version: 39.0a1 (3.0 Master)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0

Gaia is the same so it's a Gecko issue.

Gecko pushlog:
http://hg.mozilla.org/integration/b2g-inbound/pushloghtml?fromchange=ce7408061848&tochange=174750113959

Possibly caused by Bug 1114935.

Comment 7

[KTucker [:KTucker][Inactive 3/4/2016]]

Bevis, can you take at this please? This might have been caused by the landing for bug 1114935.

Comment 8

[Bevis Tseng[:bevis][:btseng](Exited)]

take this bug to follow up.

Comment 9

[Bevis Tseng[:bevis][:btseng](Exited)]

Root cause found:
1. Unexpected property 'QueryInterface' was copied from the RadioInterfaceLayer.rilContext.iccInfo to IccService.
2. In RadioInterfaceLayer, IccInfo won't be recreated when iccType is different. (from unkown -> usim, we should create GsmIccInfo to replace IccInfo.)
3. Even GsmIccInfo created according to iccType in IccService, but the QueryInterface of GsmIccInfo could be replaced with the one in IccInfo.

The solution is to pass the message delivered from ril_worker instead of RadioInterfaceLayer.rilContext.iccInfo. [1]

In addition, we should deprecate rilContext and unify the access of IccInfo from IccService.
Hence, bug 1155142 has been created to address this refactoring task.

[1] https://dxr.mozilla.org/mozilla-central/source/dom/system/gonk/RadioInterfaceLayer.js#2268

Comment 10

[Bevis Tseng[:bevis][:btseng](Exited)]

Attachment: Patch v1: Copy Icc Info from the message delivered by ril_worker instead of the one in rilContext.

Hi Edgar,

May I have your review for this quick fix?

Thanks!

Comment 11

[Edgar Chen [:edgar]]

Comment on attachment 8593714 [details] [diff] [review]
Patch v1: Copy Icc Info from the message delivered by ril_worker instead of the one in rilContext.

Review of attachment 8593714 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you.

Comment 12

[Bevis Tseng[:bevis][:btseng](Exited)]

try server is green:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=90605ff99e0b

Comment 13

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/a16c743eb437

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/b2g-inbound/rev/a16c743eb437

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a16c743eb437

Comment 16

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

since this was landed on master, it will be included in 3.0.
removing the nomination.

Comment 17

[Pi Wei Cheng [:piwei] (inactive)]

This issue is verified fixed on Flame 3.0. Under Settings > Device Information > Phone Number, it correctly shows the device's phone number. Tested with 1 SIM and 2 SIMs and it worked correctly.

Device: Flame 3.0 Master (full flashed 319MB KK)
BuildID: 20150423010203
Gaia: 9d4f756aa35cb7f030a92f3c1f65fb55254ddd1d
Gecko: 0b202671c9e2
Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b
Version: 40.0a1 (3.0 Master) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:40.0) Gecko/40.0 Firefox/40.0