Minor cleanup in nsNPAPIPlugin

RESOLVED FIXED in mozilla35

Status

()

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: johns, Assigned: johns)

Tracking

Trunk
mozilla35
Points:
---
Bug Flags:
qe-verify -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Assignee)

Description

4 years ago
From the things-in-my-patch-queue-forever file
(Assignee)

Comment 1

4 years ago
Created attachment 8483650 [details] [diff] [review]
Trailing whitespace plague in nsNPAPIPlugin

Because my editor highlights it
Attachment #8483650 - Flags: review?(benjamin)
(Assignee)

Comment 2

4 years ago
Created attachment 8483655 [details] [diff] [review]
Remove obsolete OOM check in nsNPAPIPlugin
Attachment #8483655 - Flags: review?(benjamin)
(Assignee)

Comment 3

4 years ago
Created attachment 8483659 [details] [diff] [review]
Don't leak pluginLib in nsNPAPIPlugin error path

This is not refcounted -- mLibrary is deleted in nsNPAPIPlugin's destructor. If we bail before setting plugin->mLibrary, we leak it

Updated

4 years ago
Attachment #8483655 - Flags: review?(benjamin) → review+
(Assignee)

Updated

4 years ago
Attachment #8483659 - Flags: review?(benjamin)

Updated

4 years ago
Attachment #8483650 - Flags: review?(benjamin) → review+

Updated

4 years ago
Attachment #8483659 - Flags: review?(benjamin) → review+
https://hg.mozilla.org/mozilla-central/rev/cc6ca12f7979
https://hg.mozilla.org/mozilla-central/rev/fb92ec3cabb1
https://hg.mozilla.org/mozilla-central/rev/e4d598b3b516
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.