1062469 - Minor cleanup in nsNPAPIPlugin

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[John Schoenick [:johns]]

From the things-in-my-patch-queue-forever file

Comment 1

[John Schoenick [:johns]]

Attachment: Trailing whitespace plague in nsNPAPIPlugin

Because my editor highlights it

Comment 2

[John Schoenick [:johns]]

Attachment: Remove obsolete OOM check in nsNPAPIPlugin

Comment 3

[John Schoenick [:johns]]

Attachment: Don't leak pluginLib in nsNPAPIPlugin error path

This is not refcounted -- mLibrary is deleted in nsNPAPIPlugin's destructor. If we bail before setting plugin->mLibrary, we leak it

Comment 4

[John Schoenick [:johns]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cc6ca12f7979
https://hg.mozilla.org/integration/mozilla-inbound/rev/fb92ec3cabb1
https://hg.mozilla.org/integration/mozilla-inbound/rev/e4d598b3b516

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/cc6ca12f7979
https://hg.mozilla.org/mozilla-central/rev/fb92ec3cabb1
https://hg.mozilla.org/mozilla-central/rev/e4d598b3b516