1062580 - [Browser] Overflow menu 'Show Windows' needs to call Task Manager with correct filter.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Browser Chrome, defect)

Description

[Aus Lacroix [:aus]]

The custom event should have the following event detail:

{ detail: { filter: 'browser-only' }}

Comment 1

[Aus Lacroix [:aus]]

Attachment: Pull Request - Send 'taskmanagershow' with correct filter as detail

I changed it in both app_chrome and browser_context_menu, not sure both are required as only the latter is called currently (but I distinctly remember app chrome being called instead with the new style overflow menus).

Comment 2

[Ben Francis [:benfrancis]]

Comment on attachment 8483823 [details] [review]
Pull Request - Send 'taskmanagershow' with correct filter as detail

This is correct, the AppChrome method is used for the button displayed on the Rocketbar on the browser start page.

Thanks :)

Comment 3

[Ben Francis [:benfrancis]]

Please investigate the failing unit test before landing, and request uplift to 2.1.

Comment 4

[Aus Lacroix [:aus]]

Failing test looks like a known intermittent but, I did rebase against the latest master. Hopefully everything passes this time.

https://tbpl.mozilla.org/?rev=40be0348d7b087c0eeb62b01d8a1bd3a33fe4855&tree=Gaia-Try

Comment 5

[Aus Lacroix [:aus]]

Comment on attachment 8483823 [details] [review]
Pull Request - Send 'taskmanagershow' with correct filter as detail

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): N/A
[User impact] if declined: Impossible for user to easily access browser windows via 'Show Windows' in Browser and Rocketbar. It would instead show *all* windows.
[Testing completed]: On Device (Flame Full, Flame 319).
[Risk to taking this patch] (and alternatives if risky): None.
[String changes made]: None.

Comment 6

[Aus Lacroix [:aus]]

Behold the greenness of my gaia-try run!

Commit (master): https://github.com/mozilla-b2g/gaia/commit/2ad4a6b1aa929d89f3f2fea1c6efb511b2227c0c

Leaving open, hoping for 2.1 approval. :)

Comment 7

[Aus Lacroix [:aus]]

Flagging ni? for approval-gaia-2.1. I was hoping to be able to wrap this up this week. :)

Comment 8

[Aus Lacroix [:aus]]

Commit (v2.1): https://github.com/mozilla-b2g/gaia/commit/eabddf6abe10a95d24086cc35f9633d80043ac97

Fixed!