Closed Bug 1062638 Opened 5 years ago Closed 5 years ago

crash in java.lang.NullPointerException: at org.mozilla.gecko.RemoteTabsExpandableListAdapter.getChildView(RemoteTabsExpandableListAdapter.java)

Categories

(Firefox for Android :: General, defect, critical)

All
Android
defect
Not set
critical

Tracking

()

VERIFIED FIXED
Firefox 35
Tracking Status
firefox32 --- unaffected
firefox33 --- unaffected
firefox34 + verified
firefox35 --- verified

People

(Reporter: kairo, Assigned: nalexander)

References

Details

(Keywords: crash)

Crash Data

Attachments

(1 file)

This bug was filed from the Socorro interface and is 
report bp-effd891d-063d-4ff9-a922-cd9242140903.
=============================================================

I'm seeing this crash reproducibly when trying to access remote tabs on nightly on my Nexus 10.
Blocks: 1057637
This is interesting.  The offending code is at http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/RemoteTabsExpandableListAdapter.java#142.

The two get() calls above through on index exceptions, so it's unlikely we're seeing a data corruption problem.  It's possible we have a null tab, but unlikely.  Everything's basically new and final; that would be quite hard to arrange.

That suggests that it's the titleView that's null.  If we inflate the view ourselves, it's very unlikely that we can't find R.id.title.  (I've checked the resource, and that's the correct id.)  That suggests that we're trying to convert a view and failing.  I wonder if we might get a convertView that's a group view, rather than a child view?  Investigating further.
Assignee: nobody → nalexander
Status: NEW → ASSIGNED
I've installed what looks like the offending build (based on buildid):

http://ftp.mozilla.org/pub/mozilla.org/mobile/nightly/2014-09-03-03-02-06-mozilla-central-android/fennec-35.0a1.multi.android-arm.json

I can't dupe on two devices.  I'm going to wait and see if we get more reports with this signature, and if kairo sees it with more Nightlies.
I take it all back.  This is a legit issue: I forgot to update a file on tablets only.
This should fix a reproducible hard crash on tablets.
Attachment #8483970 - Flags: review?(michael.l.comella)
This'll want local testing, a day to bake, and then immediate uplift to Aurora.
Attachment #8483970 - Flags: review?(michael.l.comella) → review+
Comment on attachment 8483970 [details] [diff] [review]
Rename tabs to title on tablets as well. r=mcomella

Approval Request Comment

[Feature/regressing bug #]: https://bugzilla.mozilla.org/show_bug.cgi?id=1057637

[User impact if declined]: hard crash in Remote Tabs tray on tablets.

[Describe test coverage new/current, TBPL]: essentially none.  I can't make crash-reports differentiate tablets from phones, but I'm confident we're seeing this only on tablets.  Pretty clear oversight updating one file and not another.

[Risks and why]: Essentially none. I suppose I could have made a second mistake?

[String/UUID change made/needed]: none.
Attachment #8483970 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/9e9af9d273f0
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
Comment on attachment 8483970 [details] [diff] [review]
Rename tabs to title on tablets as well. r=mcomella

Aurora+
Attachment #8483970 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Marking this verified fixed since there are 0 crashes reported in the last week. However, I'm also flagging this qe-verify- since QE didn't actually do a verification here.
Status: RESOLVED → VERIFIED
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.