Remove urls from new tab pings

RESOLVED FIXED in Firefox 33

Status

()

Firefox
New Tab Page
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: Mardak, Assigned: Mardak)

Tracking

Trunk
Firefox 35
Points:
---
Dependency tree / graph
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox32 unaffected, firefox33+ fixed, firefox34+ fixed, firefox35+ fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
We won't be sending url strings from Firefox, but we'll still need to identify a tile as being enhanced. The server was noting enhanced tiles as submitted tiles that include both id and url, so we'll just send "" for the url.
(Assignee)

Comment 1

3 years ago
Created attachment 8483911 [details] [diff] [review]
v1
Assignee: nobody → edilee
Status: NEW → ASSIGNED
Attachment #8483911 - Flags: review?(adw)
(Assignee)

Updated

3 years ago
Blocks: 1062708

Updated

3 years ago
Attachment #8483911 - Flags: review?(adw) → review+
(Assignee)

Comment 2

3 years ago
https://hg.mozilla.org/integration/fx-team/rev/d53ae16ca8cc
(Assignee)

Comment 3

3 years ago
Comment on attachment 8483911 [details] [diff] [review]
v1

Approval Request Comment
[Feature/regressing bug #]: Bug 1042214
[User impact if declined]: History tiles that get enhanced will send url data for both aurora (34) and beta (33) users. The only tiles being enhanced are all mozilla.org properties, so we would see urls of some mozilla sites if they are in the user's top sites. Our privacy policy allows for this data, but we don't need to collect it through Firefox anymore.
[Describe test coverage new/current, TBPL]: Tests updated
[Risks and why]: Simple change that uses an empty string instead of actual url string.
[String/UUID change made/needed]: none
Attachment #8483911 - Flags: approval-mozilla-beta?
Attachment #8483911 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/d53ae16ca8cc
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
status-firefox32: --- → unaffected
status-firefox33: --- → affected
status-firefox34: --- → affected
status-firefox35: --- → fixed
tracking-firefox33: --- → +
tracking-firefox34: --- → +
tracking-firefox35: --- → +
Comment on attachment 8483911 [details] [diff] [review]
v1

Let's avoid collecting data that we don't need. Approved for beta and aurora. Please get this landed for beta2, which goes to build on Mon, Sep 8.
Attachment #8483911 - Flags: approval-mozilla-beta?
Attachment #8483911 - Flags: approval-mozilla-beta+
Attachment #8483911 - Flags: approval-mozilla-aurora?
Attachment #8483911 - Flags: approval-mozilla-aurora+
(Assignee)

Comment 6

3 years ago
https://hg.mozilla.org/releases/mozilla-aurora/rev/ed074ae6ccac
https://hg.mozilla.org/releases/mozilla-beta/rev/c81810e5f3a5
status-firefox33: affected → fixed
status-firefox34: affected → fixed
Assigning this to Cornel for an initial assessment and verification.
Flags: qe-verify?
QA Contact: cornel.ionce
I consider this issue doesn't need manual testing so I'll mark it accordingly.

Ed, please correct me if I'm wrong and if you think it needs manual coverage.
Flags: qe-verify? → qe-verify-
You need to log in before you can comment on or make changes to this bug.