1062683 - Remove urls from new tab pings

Status: RESOLVED FIXED

(Firefox :: New Tab Page, defect)

Description

[Ed Lee :Mardak]

We won't be sending url strings from Firefox, but we'll still need to identify a tile as being enhanced. The server was noting enhanced tiles as submitted tiles that include both id and url, so we'll just send "" for the url.

Comment 1

[Ed Lee :Mardak]

Attachment: v1

Comment 2

[Ed Lee :Mardak]

https://hg.mozilla.org/integration/fx-team/rev/d53ae16ca8cc

Comment 3

[Ed Lee :Mardak]

Comment on attachment 8483911 [details] [diff] [review]
v1

Approval Request Comment
[Feature/regressing bug #]: Bug 1042214
[User impact if declined]: History tiles that get enhanced will send url data for both aurora (34) and beta (33) users. The only tiles being enhanced are all mozilla.org properties, so we would see urls of some mozilla sites if they are in the user's top sites. Our privacy policy allows for this data, but we don't need to collect it through Firefox anymore.
[Describe test coverage new/current, TBPL]: Tests updated
[Risks and why]: Simple change that uses an empty string instead of actual url string.
[String/UUID change made/needed]: none

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d53ae16ca8cc

Comment 5

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8483911 [details] [diff] [review]
v1

Let's avoid collecting data that we don't need. Approved for beta and aurora. Please get this landed for beta2, which goes to build on Mon, Sep 8.

Comment 6

[Ed Lee :Mardak]

https://hg.mozilla.org/releases/mozilla-aurora/rev/ed074ae6ccac
https://hg.mozilla.org/releases/mozilla-beta/rev/c81810e5f3a5

Comment 7

[Andrei Vaida [:avaida]]

Assigning this to Cornel for an initial assessment and verification.

Comment 8

[Cornel Ionce [:noni] [Hubs QA]]

I consider this issue doesn't need manual testing so I'll mark it accordingly.

Ed, please correct me if I'm wrong and if you think it needs manual coverage.