106269 - Reply quoted broken with HTML composing

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect, P1)

Description

[Jacek Piskozub]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Win 9x 4.90; en-US; rv:0.9.5+) Gecko/20011022
BuildID:    2001102213

Over the weekend quoting in HTML composed messages was broken. 
The replied message looks now like the original (no new quoting lines added on
the left of quoted text). Reply quoted with plain mail works OK.

Reproducible: Always
Steps to Reproduce:
1. Set HTML message compose to "on"
2. Reply to a message
3. See that it looks like the original: the quoted text lacks the quote line on
the left.

Comment 1

[Jacek Piskozub]

I'll add that the same problem exists with replying to news postings and that
the quote lines originally in the message are shown in the reply window (meaning
this is not a problem of just not rendering the lines).

Problem still exists with a fresh CVS build made on 2001102310.

Comment 2

[scottputterman]

Joe, is quoting your area?  This is a pretty important bug since it makes it
pretty hard to write and receive html mail.  If one or more of you guys (Seth,
Jean-Francois, or Joe) could look at this today, that would be greatly appreciated.

Comment 3

[(not reading, please use [e-mail] instead)]

accepting, I'll investigate.

Comment 4

[(not reading, please use [e-mail] instead)]

the blocke quote tag is missing.

<blockquote type="cite" cite="mid:[e-mail]">Just checkin'
back.... <br>

{MSG BODY}

</blockquote>

Comment 5

[Jean-Francois Ducarroz]

*** Bug 106463 has been marked as a duplicate of this bug. ***

Comment 6

[(not reading, please use [e-mail] instead)]

we're calling InsertAsCitedQuotation() with the correct cite, following into 
editor land...

Comment 7

[(not reading, please use [e-mail] instead)]

I think this might have been caused by jfrancis's checkins.

here's my guess so far:


-         res = InsertHTMLWithCharset(aQuotedText, aCharset);
+         res = LoadHTMLWithCharset(aQuotedText, aCharset);


that is called after we stuff in the blockquote node.

I think switching from insert to load means we blew away the blockquote node.

Comment 8

[(not reading, please use [e-mail] instead)]

switching back fixes it.

but I'm sure there was a good reason for switching to LoadHTMLWithCharset()

this checkin was part of the fix for several bugs.

Comment 9

[(not reading, please use [e-mail] instead)]

over to jfrancis.

Comment 10

[(not reading, please use [e-mail] instead)]

Attachment: patch

Comment 11

[(not reading, please use [e-mail] instead)]

taking back, we really need this to be fixed.

I'll send mail to the jfrancis and the editor folks for review.

Comment 12

[kinmoz]

Comment on attachment 55067 [details] [diff] [review]
patch

r/sr=[e-mail] ... go ahead and check this in and reopen bug 58629 and bug 77902 stating that you
backed out that one line.

What is the string you are passing in? Is it a blockquote around something with an HTML tag? Or do you guys
strip out everything except the contents of the BODY?

Comment 13

[kinmoz]

Looks like LoadHTMLWithCharset() is calling DeleteSelection() which 
triggers some rules code in WillDeleteSelection() which removes empty containers 
(in this case the blockquote) when the selection is collapsed.

Comment 14

[(not reading, please use [e-mail] instead)]

Attachment: new patch from kin

Comment 15

[(not reading, please use [e-mail] instead)]

Attachment: new patch, diff -uw, thanks again to kin.

Comment 16

[kinmoz]

Comment on attachment 55295 [details] [diff] [review]
new patch, diff -uw, thanks again to kin.

r/sr=[e-mail]

Check that puppy in with the 'if' brace location matching the rest of the function.

Comment 17

[(not reading, please use [e-mail] instead)]

braces style changes made.  fix checked in.  thanks again, kin.

Comment 18

[Joe Francis]

This change stands it messes up returning from source view in editor,

Comment 19

[Joe Francis]

nevermind, newest patch doesn't have the problem. thanks kin and seth.

Comment 20

[esther]

verified 2001-12-120 win, mac and linux

Comment 21

[Vadim Berezniker]

*** Bug 106318 has been marked as a duplicate of this bug. ***