1062730 - [NFC] Home button could not work well after receiving multiple websites which are shared via NFC

Status: VERIFIED FIXED

(Firefox OS Graveyard :: NFC, defect)

Description

[Alison Shiue]

Attachment: Home_button_could_not_work_well .mp4

Gaia      fbb297c39aab5f17b179533d2a9a6c5166b2c197
Gecko     https://hg.mozilla.org/releases/mozilla-aurora/rev/fb5e796da813
BuildID   20140903000204
Version   34.0a2

STR:
1. Sender device open new tab with website A
2. Sender device open another new tab with website B
3. Tap two phones together to share website B 
4. Sender device swipe to website A
5. Tap two phones together to share website A
6. Receiver device click home button 

Expect result:
Go back to home screen

Actual result:
Screen shows on website B, and swipe gesture could not work (still could long press home button to kill running apps)

Comment 1

[Alison Shiue]

[Blocking Requested - why for this release]:
Obviously error

Comment 2

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

triage: huge UX impact...
Alive, Greg you might want to check this.

Comment 3

[(inactive after 6/18) Alive Kuo [:alive]]

George, please help. Guess it's we are not cleaning something after stopping.

Comment 4

[Jason Smith [:jsmith]]

Likely a regression. Adding qawanted to confirm via branch checks.

Comment 5

[Adam Alldredge [:AdamA][Inactive]]

This issue is occurring on 2.2 Flame and 2.1 Flame.

Environmental Variables:
Device: Flame 2.2 Master
BuildID: 20140910060915
Gaia: f108c706fae43cd61628babdd9463e7695b2496e
Gecko: 843332cc69af
Version: 35.0a1 (2.2 Master)
Firmware: V123
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

Device: Flame 2.1
BuildID: 20140910075731
Gaia: daf91971902cd8e70e6cc5616159260cfcfce7c5
Gecko: 888f6e657035
Version: 34.0a2 (2.1)
Firmware: V123
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0

Result:
User is not returned to homescreen when the home button is pressed.

---------------------------------------------------------------------

This issue is not occurring on 2.0 Flame amd 1.4 Flame.

Environmental Variables:
Device: Flame 2.0
BuildID: 20140910075715
Gaia: 3f4c635106c5364228782d12b1cb76b0c105b971
Gecko: 0b64a36a0378
Version: 32.0 (2.0)
Firmware: V123
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Device: Flame 1.4
BuildID: 20140909105753
Gaia: 2ee5b00bfbb8a67a967094804390b4afce8ecf54
Gecko: faa0a4505925
Version: 30.0 (1.4)
Firmware: V123
User Agent: Mozilla/5.0 (Mobile; rv:30.0) Gecko/30.0 Firefox/30.0

Result:
User is returned to homescreen when home button is pressed.

------------------------------------------------------------------------

Open_C does not have NFC support so I was unable to check this issue on that device.

Comment 6

[(Inactive after June) George Duan [:gduan] [:喬智]]

Yes, I guess we haven't cleaned the transform effect when shrinking is done.

Comment 7

[(Inactive after June) George Duan [:gduan] [:喬智]]

We should have a way to stop previous app's tilting effect before launching a new window or app.

Comment 8

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: PR to master

Hi Alive,
could you review this patch?
thanks.

Comment 9

[Adam Alldredge [:AdamA][Inactive]]

B2G-Inbound Regression window:

Last working:
Device: Flame 2.1
BuildID: 20140901212013
Gaia: 82df767ab641da98a02d45a168b4ff9096e1d7b4
Gecko: 67e9cbbbde1b
Version: 34.0a1 (2.1)
Firmware: V123
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0

First Broken:
Device: Flame 2.1
BuildID: 20140901215313
Gaia: 59bd6619d64979f32179732f6de83f9a4f611367
Gecko: 20d4376a87ed
Version: 34.0a1 (2.1)
Firmware: V123
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0

Last working Gaia First Broken Gecko: Issue does NOT reproduce
Gaia: 82df767ab641da98a02d45a168b4ff9096e1d7b4
Gecko: 20d4376a87ed

First Broken Gaia Last working Gecko: Issue DOES reproduce
Gaia: 59bd6619d64979f32179732f6de83f9a4f611367
Gecko: 67e9cbbbde1b

Pushlog:
https://github.com/mozilla-b2g/gaia/compare/82df767ab641da98a02d45a168b4ff9096e1d7b4...59bd6619d64979f32179732f6de83f9a4f611367

Caused by Bug 1059093

Comment 10

[Joshua Mitchell (Inactive)]

Caused by Bug 1059093 - can you take a look

Comment 11

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8487798 [details] [review]
PR to master

Not an idea way to publish shrinking-stop in AWM.

Comment 12

[Greg Weng [:snowmantw][:gweng][:λ]]

Alive's opinion on GitHub page is reasonable.

Comment 13

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8487798 [details] [review]
PR to master

Hi Alive,
I updated my patch based on your suggestion. could I have your feedback before completing test? Thanks.

Comment 14

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8487798 [details] [review]
PR to master

Hi Alive,
patch updated, could you check again? Thanks.

Comment 15

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8487798 [details] [review]
PR to master

r+ with nits. Please make the new code passes the test and pay attention to this._activeApp is null case.

Comment 16

[(Inactive after June) George Duan [:gduan] [:喬智]]

Thanks,
master: https://github.com/mozilla-b2g/gaia/commit/a3844c9e93dbad9d831efaf6e778d4312ae63c56

Comment 17

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for Gaia v2.1 approval when you get a chance.

Comment 18

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: PR to 2.1

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Bug 1059093
[User impact] if declined: as comment 0
[Testing completed]: Yes
[Risk to taking this patch] (and alternatives if risky): No.
[String changes made]:

Comment 19

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/d6645ed36f9a446c9dfcc87c3e0d859450c6b34f

Comment 20

[Alison Shiue]

Verified on KK
[2.1]
Gaia-Rev        13973ab50760d1e8bb773082163f0dff19d35a44
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-aurora/rev/6e317e075d04
Build-ID        20140928160204
Version         34.0a2

[2.2]
Gaia-Rev        2834baf4c7e34fe6ef335f0469f6d0f593c5922b
Gecko-Rev       https://hg.mozilla.org/mozilla-central/rev/6a63bcb6e0d3
Build-ID        20140928160202
Version         35.0a1

Comment 21

[Sue]

Attachment: video of issue verify

This issue has been successfully verified on Flame 2.1
See attachment: verify_video.MP4
Reproducing rate: 0/5
Flame 2.1 versions:
Gaia-Rev        f8d3bf44029e0afc0124600a4bb34dba8fc1ad21
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/f70a67a7f846
Build-ID        20141120001207
Version         34.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141120.034911
FW-Date         Thu Nov 20 03:49:22 EST 2014
Bootloader      L1TC00011880