1062809 - [Contacts] Strange icon shown in the ICE Contact list when the Contact doesn't have picture

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Loli (:lolimartinezcr)]

Attachment: 2014-09-04-09-10-07.png

Flame
2.1
Gecko-0b0325e
Gaia-a47ecb6

Pre-requisites:
Contact created.

STRs:
1. Tap contact application.
2. Tap "settings" button.
3. Tap "Set ICE contacts".
4. Swith ON "ICE Contact 1".
5. Select a contact.
6. Tap back button.
7. Tap "Done" button. -> Actual Result 1
8. Tap "ICE contacts" button -> Actual result 2

Actual result 1:
See 2014-09-04-09-10-07.png

Actual result 2:
See 2014-09-04-09-10-14.png

Expected result:
Icons correct.

Comment 1

[Loli (:lolimartinezcr)]

Attachment: 2014-09-04-09-10-14.png

Comment 2

[Maria Angeles Oteo (:oteo)]

Thanks Loli for open this issue :)

Just to comment that the Pre-requisites is a Contact created WITHOUT PHOTO

You can see in the attached screenshots that for a contact without photo the the initial letter of the contact should be shown (as it's in the contact list) but in the ICE section it's shown an strange image

[Blocking Requested - why for this release]: it's really confusing and not coherent with the picture shown in the contact list

Comment 4

[Paco Rampas [:paco]]

Attachment: patch in github

Comment 5

[Paco Rampas [:paco]]

Attachment: ice-default-img.png

Comment 6

[Paco Rampas [:paco]]

Attachment: ice-default-img.png

Comment 7

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8486321 [details] [review]
patch in github

Good catch ;)

Thanks Paco!

Comment 8

[Francisco Jordano [:arcturus] [:francisco]]

Landed:

https://github.com/mozilla-b2g/gaia/commit/8e02f689b0fc39cb6ccdc22d02ed7e219c58faa7

Comment 9

[Loli (:lolimartinezcr)]

Pending to test in 2.1

Comment 10

[Loli (:lolimartinezcr)]

(In reply to Loli (:lolimartinezcr) from comment #9)
> Pending to test in 2.1

Tested in 2.2 and working
Flame 
Gecko ca03f2d
Gaia 73a7ace

Pending 2.1

Comment 11

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8486321 [details] [review]
patch in github

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
ICE feature
[User impact] if declined:
Bad user experience
[Testing completed]:
Smoke tests, passed.
[Risk to taking this patch] (and alternatives if risky):
Low, since we just missed a parameter, now present
[String changes made]:

Comment 12

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/aa4bbd2cc03fd5107ef0268feb21e09f8ff0c9f9

Comment 13

[Loli (:lolimartinezcr)]

Tested and *not* working in 2.1, i can see again 2014-09-04-09-10-07.png.
Gecko 3953700
Gaia 713448b

Comment 14

[Loli (:lolimartinezcr)]

Tested and working
2.1
Flame
User
Gecko-bdd77c4
Gaia-b3f9b97

Comment 15

[Elie]

This issue has been successfully verified on Flame 2.1:
Gaia-Rev        1bdd49770e2cb7a7321e6202c9bf036ab5d8f200
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/db893274d9a6
Build-ID        20141125001201
Version         34.0
Device-Name     flame
FW-Release      4.4.2


This issue has been successfully verified on Flame 2.2:
Gaia-Rev        824a61cccec4c69be9a86ad5cb629a1f61fa142f
Gecko-Rev       https://hg.mozilla.org/mozilla-central/rev/acde07cb4e4d
Build-ID        20141125040209
Version         36.0a1
Device-Name     flame
FW-Release      4.4.2

Comment 16

[Elie]

Attachment: VIDEO0059_Compress.MP4