1062814 - [Contact][Refresh follow up] Label menu button are not in the right position and size

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Fang Shih [:fang]]

Attachment: contact label_bug.png

The label button needs to leave space in two sides and also for the top. Please refer to the file attached for screenshots. Thanks!

Comment 1

[Fang Shih [:fang]]

[Blocking Requested - why for this release]:

Comment 2

[Francisco Jordano [:arcturus] [:francisco]]

We touch a css for the lists that is making us have some regressions.

Same than bug 1064203.

Comment 5

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

triage: obvious UI defect.

Comment 6

[Dietrich Ayala (:dietrich)]

Triage looked at this bug, and it's not a problem that would block the entire release. Please reference the blocker criteria to understand what type of issues block a whole release: https://wiki.mozilla.org/B2G/Triage#Blocker_Triage_Guidelines.

Also, the tree isn't closed to blockers-only yet, so once you fix this you can ask for approval on the patch from Fabrice or Bhavana to land ;)

Comment 7

[Jose Manuel Cantera]

Attachment: 23941.html

Comment 8

[Jose Manuel Cantera]

Fang, 

I've proposed a patch with a 1rem of margin for buttons. Please let me know if that's the correct value

thanks!

Comment 9

[Fang Shih [:fang]]

Comment on attachment 8487744 [details]
23941.html

Hi Jose, It looks ok before I clicked on another button. Once I clicked on another button, then the one I clicked before extend to longer size. I'll take a screenshot to show what I see. Thanks!

Comment 10

[Fang Shih [:fang]]

Attachment: Bug 1062814.png

Attached is the screenshot.

Comment 11

[Jose Manuel Cantera]

Comment on attachment 8487744 [details]
23941.html

well spotted Fang. Please check now it should be fixed

thanks!

Comment 12

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8487744 [details]
23941.html

Hi Jose, this bug duplicates also bug 1063395, related to the buttons in the import and export sections.

We definitely modified the styles on the list when redoing the form, can we fix also in this PR that problem?

Thanks!

Comment 13

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8487744 [details]
23941.html

Just saw a different patch for the import exports.

So let's get in

Comment 14

[Francisco Jordano [:arcturus] [:francisco]]

Jose can you get an image of the tag list before and after the patch?

Comment 15

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8487744 [details]
23941.html

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
Contact redesign form feature
[User impact] if declined:
Really bad user experience
[Testing completed]:
Smoke tests done
[Risk to taking this patch] (and alternatives if risky):
Pretty low, we are just adding css
[String changes made]:

Comment 16

[Jose Manuel Cantera]

:Fang,

Plese could you have a final look, we need it in order to land this asap

Comment 17

[Fang Shih [:fang]]

Comment on attachment 8487744 [details]
23941.html

Looks good!!! Thanks!

Comment 18

[Jose Manuel Cantera]

landed master: 

https://github.com/mozilla-b2g/gaia/commit/a296759a990321147ec274a80c2a88f22e1abe1d

Comment 19

[Loli (:lolimartinezcr)]

Tested and working
2.2
Flame
Gecko-713c41b
Gaia-32d82d2

Comment 20

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/9a880e2e74c29d975e3333c3bf3652a052cb9c14

Comment 21

[Loli (:lolimartinezcr)]

Tested and working
2.1
Flame
Gecko: 3953700
Gaia: 713448b

Comment 22

[Lancy(Leave from Mozilla)]

Attachment: Verify_1062814_Screenshot.png

This issue has been verified successfully on Flame 2.0& 2.1 & 2.2.
See attachment: Verify_1062814_Screenshot.png
Reproducing rate: 0/10

FLame 2.0 version:
Gaia-Rev        f9d6e3d83c3922e9399a6c27f5ce4cdd27bdfd05
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/45112935086f
Build-ID        20141126000203
Version         32.0

Flame v2.1 version:
Gaia-Rev        db2e84860f5a7cc334464618c6ea9e92ff82e9dd
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/211eae88f119
Build-ID        20141126001202
Version         34.0

Flame 2.2 version:
Gaia-Rev        41b7be7c67167f367c3c4982ff08651d55455373
Gecko-Rev       https://hg.mozilla.org/mozilla-central/rev/ff4a63d66806
Build-ID        20141126160201
Version         36.0a1