Closed
Bug 1062814
Opened 10 years ago
Closed 10 years ago
[Contact][Refresh follow up] Label menu button are not in the right position and size
Categories
(Firefox OS Graveyard :: Gaia::Contacts, defect)
Tracking
(tracking-b2g:backlog, b2g-v2.0 verified, b2g-v2.1 verified, b2g-v2.2 verified)
People
(Reporter: fang, Assigned: jmcf)
References
Details
(Keywords: regression)
Attachments
(4 files)
61.66 KB,
image/png
|
Details | |
191 bytes,
text/html
|
arcturus
:
review+
fang
:
ui-review+
bajaj
:
approval-gaia-v2.1+
|
Details |
33.14 KB,
image/png
|
Details | |
33.73 KB,
image/png
|
Details |
The label button needs to leave space in two sides and also for the top. Please refer to the file attached for screenshots. Thanks!
Reporter | ||
Updated•10 years ago
|
Target Milestone: --- → 2.1 S4 (12sep)
Reporter | ||
Comment 1•10 years ago
|
||
[Blocking Requested - why for this release]:
blocking-b2g: --- → 2.1?
Comment 2•10 years ago
|
||
We touch a css for the lists that is making us have some regressions. Same than bug 1064203.
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → jmcf
Comment 6•10 years ago
|
||
Triage looked at this bug, and it's not a problem that would block the entire release. Please reference the blocker criteria to understand what type of issues block a whole release: https://wiki.mozilla.org/B2G/Triage#Blocker_Triage_Guidelines. Also, the tree isn't closed to blockers-only yet, so once you fix this you can ask for approval on the patch from Fabrice or Bhavana to land ;)
blocking-b2g: 2.1+ → backlog
Assignee | ||
Comment 7•10 years ago
|
||
Attachment #8487744 -
Flags: ui-review?(fshih)
Attachment #8487744 -
Flags: review?(francisco)
Assignee | ||
Comment 8•10 years ago
|
||
Fang, I've proposed a patch with a 1rem of margin for buttons. Please let me know if that's the correct value thanks!
Updated•10 years ago
|
status-b2g-v2.0:
--- → fixed
status-b2g-v2.1:
--- → affected
status-b2g-v2.2:
--- → affected
Keywords: regression
Reporter | ||
Comment 9•10 years ago
|
||
Comment on attachment 8487744 [details]
23941.html
Hi Jose, It looks ok before I clicked on another button. Once I clicked on another button, then the one I clicked before extend to longer size. I'll take a screenshot to show what I see. Thanks!
Attachment #8487744 -
Flags: ui-review?(fshih) → ui-review-
Assignee | ||
Comment 11•10 years ago
|
||
Comment on attachment 8487744 [details]
23941.html
well spotted Fang. Please check now it should be fixed
thanks!
Attachment #8487744 -
Flags: ui-review- → ui-review?(fshih)
Comment 12•10 years ago
|
||
Comment on attachment 8487744 [details] 23941.html Hi Jose, this bug duplicates also bug 1063395, related to the buttons in the import and export sections. We definitely modified the styles on the list when redoing the form, can we fix also in this PR that problem? Thanks!
Attachment #8487744 -
Flags: review?(francisco)
Comment 13•10 years ago
|
||
Comment on attachment 8487744 [details]
23941.html
Just saw a different patch for the import exports.
So let's get in
Attachment #8487744 -
Flags: review+
Comment 15•10 years ago
|
||
Comment on attachment 8487744 [details]
23941.html
[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
Contact redesign form feature
[User impact] if declined:
Really bad user experience
[Testing completed]:
Smoke tests done
[Risk to taking this patch] (and alternatives if risky):
Pretty low, we are just adding css
[String changes made]:
Attachment #8487744 -
Flags: approval-gaia-v2.1?(bbajaj)
Assignee | ||
Comment 16•10 years ago
|
||
:Fang, Plese could you have a final look, we need it in order to land this asap
Flags: needinfo?(fshih)
Reporter | ||
Comment 17•10 years ago
|
||
Comment on attachment 8487744 [details]
23941.html
Looks good!!! Thanks!
Attachment #8487744 -
Flags: ui-review?(fshih) → ui-review+
Flags: needinfo?(fshih)
Assignee | ||
Comment 18•10 years ago
|
||
landed master: https://github.com/mozilla-b2g/gaia/commit/a296759a990321147ec274a80c2a88f22e1abe1d
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Updated•10 years ago
|
Updated•10 years ago
|
Attachment #8487744 -
Flags: approval-gaia-v2.1?(bbajaj) → approval-gaia-v2.1+
Comment 20•10 years ago
|
||
v2.1: https://github.com/mozilla-b2g/gaia/commit/9a880e2e74c29d975e3333c3bf3652a052cb9c14
Comment 21•10 years ago
|
||
Tested and working 2.1 Flame Gecko: 3953700 Gaia: 713448b
Status: RESOLVED → VERIFIED
Comment 22•10 years ago
|
||
This issue has been verified successfully on Flame 2.0& 2.1 & 2.2. See attachment: Verify_1062814_Screenshot.png Reproducing rate: 0/10 FLame 2.0 version: Gaia-Rev f9d6e3d83c3922e9399a6c27f5ce4cdd27bdfd05 Gecko-Rev https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/45112935086f Build-ID 20141126000203 Version 32.0 Flame v2.1 version: Gaia-Rev db2e84860f5a7cc334464618c6ea9e92ff82e9dd Gecko-Rev https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/211eae88f119 Build-ID 20141126001202 Version 34.0 Flame 2.2 version: Gaia-Rev 41b7be7c67167f367c3c4982ff08651d55455373 Gecko-Rev https://hg.mozilla.org/mozilla-central/rev/ff4a63d66806 Build-ID 20141126160201 Version 36.0a1
Updated•10 years ago
|
Updated•10 years ago
|
blocking-b2g: backlog → ---
tracking-b2g:
--- → backlog
You need to log in
before you can comment on or make changes to this bug.
Description
•