Closed
Bug 1062942
Opened 10 years ago
Closed 10 years ago
[Browser Start Page] visual tweaks
Categories
(Firefox OS Graveyard :: Gaia::Browser, defect)
Tracking
(b2g-v2.1 verified, b2g-v2.2 verified)
VERIFIED
FIXED
2.1 S4 (12sep)
People
(Reporter: epang, Assigned: kgrandon)
References
Details
(Keywords: polish, Whiteboard: [systemsfe])
Attachments
(3 files, 1 obsolete file)
Minor updates to sub headers div lines and text ('Top Sites' and 'History) on the browser start page.
- Update div lines to #e5e5e5
- Update text to #a6a6a6, medium weight
Specs can be found here:
https://mozilla.box.com/s/ac65vfmuq1ywl9s2wkqc
Thanks!
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → kgrandon
Status: NEW → ASSIGNED
Target Milestone: --- → 2.1 S4 (12sep)
Assignee | ||
Comment 1•10 years ago
|
||
(In reply to Eric Pang [:epang] from comment #0)
> - Update text to #a6a6a6, medium weight
So we don't have the ability to specify "medium". "Normal" is font-weight of 400, heavy being 800. Let's go with a 600 and see what you think.
Assignee | ||
Comment 2•10 years ago
|
||
Assignee | ||
Comment 3•10 years ago
|
||
Comment on attachment 8484316 [details] [review]
Github pull request
Eric - These seem to be just some simple CSS fixes, so if you're comfortable could you throw an R+ on it if the visuals look good? Attaching a screenshot shortly for ease of review.
Attachment #8484316 -
Flags: review?(epang)
Assignee | ||
Comment 4•10 years ago
|
||
Assignee | ||
Updated•10 years ago
|
Summary: [Browser Start Page] → [Browser Start Page] visual tweaks
Assignee | ||
Comment 5•10 years ago
|
||
Attachment #8484329 -
Attachment is obsolete: true
Reporter | ||
Comment 6•10 years ago
|
||
Comment on attachment 8484316 [details] [review]
Github pull request
Looks good! Thanks!
Attachment #8484316 -
Flags: review?(epang) → review+
Assignee | ||
Comment 7•10 years ago
|
||
Assignee | ||
Comment 8•10 years ago
|
||
Comment on attachment 8484316 [details] [review]
Github pull request
This is very low risk visual polish (css only), that we would like to uplift to 2.1.
Attachment #8484316 -
Flags: approval-gaia-v2.1?(bbajaj)
Updated•10 years ago
|
Attachment #8484316 -
Flags: approval-gaia-v2.1?(bbajaj) → approval-gaia-v2.1+
Comment 9•10 years ago
|
||
status-b2g-v2.1:
--- → fixed
status-b2g-v2.2:
--- → fixed
Comment 10•10 years ago
|
||
This issue has been verified successfully on Flame2.1&2.2.
Reproducing rate: 0/5
See attachment: Verify_Flame_Browser.png
Flame2.1 build version:
Gaia-Rev dbaf3e31c9ba9c3436e074381744f2971e15c7bf
Gecko-Rev https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/ebce587d2194
Build-ID 20141203001205
Version 34.0
Flame2.2 build version:
Gaia-Rev 725685831f5336cf007e36d9a812aad689604695
Gecko-Rev https://hg.mozilla.org/mozilla-central/rev/2c9781c3e9b5
Build-ID 20141203040207
Version 37.0a1
Comment 11•10 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•